udev: sleep_for_dev() bits

udev: sleep_for_dev() bits

[Robert Love]

OK, I fixed that bug you hinted at earlier in my previous
sleep_for_dev() patch.  I am sure you fixed it, but here we go
nonetheless, just in case.

I actually changed it up a bit.  It is probably faster to count down
from SECONDS_TO_WAIT_FOR_DEV than count up.

I also made the lone 'path' argument const, since it can be.

Some other misc. bits, too.

Patch is against udev-004.

	Robert Love


 udev-add.c |   15 +++++++--------
 1 files changed, 7 insertions(+), 8 deletions(-)

diff -urN udev-004/udev-add.c udev/udev-add.c
--- udev-004/udev-add.c	2003-10-20 17:39:08.000000000 -0400
+++ udev/udev-add.c	2003-10-22 00:09:48.820010080 -0400
@@ -130,24 +130,23 @@
  * If it doesn't happen in about 10 seconds, give up.
  */
 #define SECONDS_TO_WAIT_FOR_DEV		10
-int sleep_for_dev(char *path)
+static int sleep_for_dev(const char *path)
 {
 	char filename[SYSFS_PATH_MAX + 6];
-	struct stat buf;
-	int loop = 0;
-	int retval = -ENODEV;
+	int loop = SECONDS_TO_WAIT_FOR_DEV;
+	int retval;
 
 	strcpy(filename, sysfs_path);
 	strcat(filename, path);
 	strcat(filename, "/dev");
 
-	while (loop < SECONDS_TO_WAIT_FOR_DEV) {
+	while (loop--) {
+		struct stat buf;
+
 		dbg("looking for %s", filename);
 		retval = stat(filename, &buf);
-		if (retval = 0) {
-			retval = 0;
+		if (!retval)
 			goto exit;
-		}
 
 		/* sleep for a second or two to give the kernel a chance to
 		 * create the dev file */





-------------------------------------------------------
This SF.net email is sponsored by OSDN developer relations
Here's your chance to show off your extensive product knowledge
We want to know what you know. Tell us and you have a chance to win $100
http://www.zoomerang.com/survey.zgi?HRPT1X3RYQNC5V4MLNSV3E54
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: udev: sleep_for_dev() bits

[Greg KH]

On Wed, Oct 22, 2003 at 12:13:45AM -0400, Robert Love wrote:
> OK, I fixed that bug you hinted at earlier in my previous
> sleep_for_dev() patch.  I am sure you fixed it, but here we go
> nonetheless, just in case.
> 
> I actually changed it up a bit.  It is probably faster to count down
> from SECONDS_TO_WAIT_FOR_DEV than count up.
> 
> I also made the lone 'path' argument const, since it can be.
> 
> Some other misc. bits, too.
> 
> Patch is against udev-004.

Thanks, I merged this with your other patch and applied it.

greg k-h


-------------------------------------------------------
This SF.net email is sponsored by OSDN developer relations
Here's your chance to show off your extensive product knowledge
We want to know what you know. Tell us and you have a chance to win $100
http://www.zoomerang.com/survey.zgi?HRPT1X3RYQNC5V4MLNSV3E54
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel