From: Greg KH <greg@kroah.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: [patch] udev: another canidate for static
Date: Tue, 21 Oct 2003 20:49:35 +0000 [thread overview]
Message-ID: <marc-linux-hotplug-106680720217836@msgid-missing> (raw)
On Tue, Oct 21, 2003 at 03:10:31PM -0400, Robert Love wrote:
> Another one of those "trivial patches so everything must be good"
>
> sleep_for_dev() isn't exported or defined in a header, so it can be
> marked 'static'
>
> Yes, I use gcc to detect these things :)
Heh, nice. Too bad you missed the bug in that function :)
I forgot to actually increase the loop variable so that we time out
eventually. Right now we just sit and spin forever. Not nice at all...
> Patch is against udev-004.
Thanks, I've applied this.
What is the argument to gcc to catch stuff like this?
thanks,
greg k-h
-------------------------------------------------------
This SF.net email is sponsored by OSDN developer relations
Here's your chance to show off your extensive product knowledge
We want to know what you know. Tell us and you have a chance to win $100
http://www.zoomerang.com/survey.zgi?HRPT1X3RYQNC5V4MLNSV3E54
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next reply other threads:[~2003-10-21 20:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-21 20:49 Greg KH [this message]
2003-10-21 21:05 ` [patch] udev: another canidate for static Robert Love
2003-10-21 23:17 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-hotplug-106680720217836@msgid-missing \
--to=greg@kroah.com \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).