From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Tue, 21 Oct 2003 20:49:35 +0000 Subject: Re: [patch] udev: another canidate for static Message-Id: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Tue, Oct 21, 2003 at 03:10:31PM -0400, Robert Love wrote: > Another one of those "trivial patches so everything must be good" > > sleep_for_dev() isn't exported or defined in a header, so it can be > marked 'static' > > Yes, I use gcc to detect these things :) Heh, nice. Too bad you missed the bug in that function :) I forgot to actually increase the loop variable so that we time out eventually. Right now we just sit and spin forever. Not nice at all... > Patch is against udev-004. Thanks, I've applied this. What is the argument to gcc to catch stuff like this? thanks, greg k-h ------------------------------------------------------- This SF.net email is sponsored by OSDN developer relations Here's your chance to show off your extensive product knowledge We want to know what you know. Tell us and you have a chance to win $100 http://www.zoomerang.com/survey.zgi?HRPT1X3RYQNC5V4MLNSV3E54 _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel