Re: [ANNOUNCE] udev 004 release

[Ananth N Mavinakayanahalli <ananth@in.ibm.com>]

On Tue, Oct 21, 2003 at 01:50:46PM -0700, Greg KH wrote:
> On Tue, Oct 21, 2003 at 10:34:04PM +0200, Kay Sievers wrote:
> > On Tue, Oct 21, 2003 at 09:28:56AM -0700, Greg KH wrote:
> > > Hi,
> > > 
> > > I've released the 004 version of udev.  It can be found at:
> > > 	kernel.org/pub/linux/utils/kernel/hotplug/udev-004.tar.gz
> > 
> > and a patch for namdev.c comments + debug
> > o correct 'device device'

I suppose the original code is correct. If we do not find the attribute
in the "class device" attributes list, look for the attribute in the
actual (physical) "device" for this class device. However, the code 
does not seem to look for the attribute in the class_dev(_parent)->sysdevice.
Inlined below is a patch to correct this.

Thanks,
Ananth
-- 
Ananth Narayan <ananth@in.ibm.com>
Linux Technology Center,
IBM Software Lab, INDIA


diff -Naur udev-004/namedev.c temp/udev-004/namedev.c
--- udev-004/namedev.c	2003-10-20 14:12:44.000000000 +0500
+++ temp/udev-004/namedev.c	2003-10-22 14:05:25.000000000 +0500
@@ -568,9 +568,9 @@
 			if (tmpattr)
 				goto label_found;
 
-			/* look in the class device device directory if present */
+			/* look in the "device" directory of the class device if present */
 			if (class_dev->sysdevice) {
-				tmpattr = sysfs_get_classdev_attr(class_dev, dev->sysfs_file);
+				tmpattr = sysfs_get_device_attr(class_dev->sysdevice, dev->sysfs_file);
 				if (tmpattr)
 					goto label_found;
 			}
@@ -601,9 +601,9 @@
 					if (tmpattr) 
 						goto label_found;
 
-					/* look in the class device device directory if present */
+					/* look in the "device" directory of the class device if present */
 					if (class_dev_parent->sysdevice) {
-						tmpattr = sysfs_get_classdev_attr(class_dev_parent, dev->sysfs_file);
+						tmpattr = sysfs_get_device_attr(class_dev_parent->sysdevice, dev->sysfs_file);
 						if (tmpattr) 
 							goto label_found;
 					}


-------------------------------------------------------
This SF.net email is sponsored by OSDN developer relations
Here's your chance to show off your extensive product knowledge
We want to know what you know. Tell us and you have a chance to win $100
http://www.zoomerang.com/survey.zgi?HRPT1X3RYQNC5V4MLNSV3E54
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel