linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Olaf Hering <olh@suse.de>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] DESTDIR for udev
Date: Wed, 29 Oct 2003 20:03:13 +0000	[thread overview]
Message-ID: <marc-linux-hotplug-106745790710455@msgid-missing> (raw)
In-Reply-To: <marc-linux-hotplug-106735713126878@msgid-missing>

 On Wed, Oct 29, Greg KH wrote:

> On Wed, Oct 29, 2003 at 12:56:55PM +0100, Olaf Hering wrote:
> >  On Wed, Oct 29, Olaf Hering wrote:
> > 
> > >  On Tue, Oct 28, Greg KH wrote:
> > > 
> > > > On Tue, Oct 28, 2003 at 05:04:06PM +0100, Olaf Hering wrote:
> > > > > For these distro guys.
> > > > > make install DESTDIR=/tmp/foobar
> > > > 
> > > > What's wrong with the existing makefile where you can do:
> > > > 	make install prefix=/tmp/foobar
> > > > 
> > > > That's what the RPM currently does.
> > > 
> > > The hotplug symlink looks bogus. DESTDIR is for packaging, not for
> > > --prefix.
> 
> Are these names documented as the default somewhere in the LSB or
> something like it?  What's wrong with using prefix in the rpm file?
> 
> > This is a more complete patch.
> > You already noticed the bogus symlink /etc/hotplug.d/default/udev.hotplug
> 
> Why is it bogus?  I couldn't get rpm to pick up the symlink any other
> way.  It looks like your patch just gets rid of it alltogether, right?
> That's not good.

How do I explain that to you. Lets try it that way:
pick your current spec file and build the rpm as user. It will not work
because you can not write below /etc or /sbin as example.
You use prefix=$RPM_BUILD_ROOT to workaround that fact. The symlink,
created in the Makefile will be:
ln -sv /var/tmp/udev-root/sbin/udev /var/tmp/udev-root/etc/hotplug.d/default
With my patch it will be
ln -sv /sbin/udev /var/tmp/udev-root/etc/hotplug.d/default

no need to remove it and recreate it manually in the specfile.

DESTDIR= is used in many projects to install the files for packaging in
the temporary directory. 


-- 
USB is for mice, FireWire is for men!

sUse lINUX ag, n√úRNBERG


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

  parent reply	other threads:[~2003-10-29 20:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-28 16:04 [PATCH] DESTDIR for udev Olaf Hering
2003-10-29  1:52 ` Greg KH
2003-10-29  6:54 ` Olaf Hering
2003-10-29 11:56 ` Olaf Hering
2003-10-29 19:28 ` Greg KH
2003-10-29 20:03 ` Olaf Hering [this message]
2003-10-29 22:27 ` Greg KH
2003-10-29 22:30 ` Adrien Beau
2003-10-29 22:32 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-hotplug-106745790710455@msgid-missing \
    --to=olh@suse.de \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).