From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Wed, 29 Oct 2003 22:27:04 +0000 Subject: Re: [PATCH] DESTDIR for udev Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Wed, Oct 29, 2003 at 09:03:13PM +0100, Olaf Hering wrote: > On Wed, Oct 29, Greg KH wrote: > > > On Wed, Oct 29, 2003 at 12:56:55PM +0100, Olaf Hering wrote: > > > On Wed, Oct 29, Olaf Hering wrote: > > > > > > > On Tue, Oct 28, Greg KH wrote: > > > > > > > > > On Tue, Oct 28, 2003 at 05:04:06PM +0100, Olaf Hering wrote: > > > > > > For these distro guys. > > > > > > make install DESTDIR=/tmp/foobar > > > > > > > > > > What's wrong with the existing makefile where you can do: > > > > > make install prefix=/tmp/foobar > > > > > > > > > > That's what the RPM currently does. > > > > > > > > The hotplug symlink looks bogus. DESTDIR is for packaging, not for > > > > --prefix. > > > > Are these names documented as the default somewhere in the LSB or > > something like it? What's wrong with using prefix in the rpm file? > > > > > This is a more complete patch. > > > You already noticed the bogus symlink /etc/hotplug.d/default/udev.hotplug > > > > Why is it bogus? I couldn't get rpm to pick up the symlink any other > > way. It looks like your patch just gets rid of it alltogether, right? > > That's not good. > > How do I explain that to you. Lets try it that way: > pick your current spec file and build the rpm as user. It will not work > because you can not write below /etc or /sbin as example. > You use prefix=$RPM_BUILD_ROOT to workaround that fact. The symlink, > created in the Makefile will be: > ln -sv /var/tmp/udev-root/sbin/udev /var/tmp/udev-root/etc/hotplug.d/default > With my patch it will be > ln -sv /sbin/udev /var/tmp/udev-root/etc/hotplug.d/default > > no need to remove it and recreate it manually in the specfile. Ok, that makes more sense now, thanks. > DESTDIR= is used in many projects to install the files for packaging in > the temporary directory. Ok, I've applied your last patch for the Makefile and the spec file and tested that it still builds a useful rpm file. thanks again for the patch, greg k-h ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/ _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel