From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Thu, 13 Nov 2003 06:23:25 +0000 Subject: Re: [udev] updated man, subdirs, ownership, namedev enum patches Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Wed, Nov 12, 2003 at 02:23:30PM +0100, Kay Sievers wrote: > On Tue, Nov 11, 2003 at 07:53:55PM -0800, Greg KH wrote: > > On Wed, Nov 05, 2003 at 08:31:28PM +0100, Kay Sievers wrote: > > > 04-namedev.c-cleanup.diff > > > remove part of udev that appends the kernel enumeration to character devices > > > in LABEL method: NAME="webcam" results in /udev/webcam0 > > > > I think this patch breaks partition naming, did you try it on them? > > Hm, are you sure this patch is correct? > > I think so, block devices are handled at line 580. At line 626 the last > digit from kernel name is appended to _every_ device including char devs. > Partition naming seems ok with the patch, but i may miss something here. Hm, if you take those lines out, I can't name a partition with the number at the end of the name. Yeah, that's a hack, and I need to fix it up. > > What happened to your other one > > where you could put a '%' in the string to put the number into the name? > > Alternate patch is attached, but i don't know if it is really useful. > It substitutes the '%' placeholder in NAME= with the kernel device > number. I think we need more than just a %. Users might care about a few things for the name. Like major, minor, and kernel device number (but it's tricky to figure out what a device number is, think of sdaa...) I'll work on fixing this up next. thanks, greg k-h ------------------------------------------------------- This SF.Net email sponsored by: ApacheCon 2003, 16-19 November in Las Vegas. Learn firsthand the latest developments in Apache, PHP, Perl, XML, Java, MySQL, WebDAV, and more! http://www.apachecon.com/ _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel