Re: [PATCH] more robust config file parsing in udev/devnaming.c

[Greg KH <greg@kroah.com>]

On Tue, Nov 18, 2003 at 06:29:25PM +0100, Arnd Bergmann wrote:
> After getting a number of different crashes for udev reading broken
> udev.config files, I decided to try to make the parser a little
> more robust.
> 
> The behaviour is changed to stop reading the configuration file
> and logging the broken entry instead of silently ignoring it (is
> that good? It's easy to just print and continue).
> All strcpy()'s to a fixed length string are now implicitly limited
> to the bounds of the target string.
> 
> I kept the -ENODEV return code for now, not sure if there should be
> different ones.

Thanks a lot for this patch, I've applied it.  We should probably
continue on, and not die if we can't read a line of the config file,
that's the nicest way :)

thanks,

greg k-h


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel