Re: [udev] udev-test.pl - automatic testing script

[Kay Sievers <kay.sievers@vrfy.org>]

[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]

On Sat, Nov 22, 2003 at 09:49:18PM -0800, Greg KH wrote:
> On Sun, Nov 23, 2003 at 04:54:09AM +0100, Kay Sievers wrote:
> > On Sat, Nov 22, 2003 at 03:41:10PM +0100, Kay Sievers wrote:
> > > here is a automatic udev test script. To test place it in the test/
> > > directory of the current tree to find the sysfs tree copy and run it.
> > > 
> > > The whole test is self contained, it only needs a matching sysfs tree.
> > > To extend the test add a hash to the @tests array inside the script.
> > > The script checks the created node and prints a summary of all tests.
> > > 
> > > Please don't change $udev_root to something useful, its a temorary
> > > directory and will be removed after the test run.
> > 
> > Here is a slightly better version that runs 'tree' on error
> > and prints a description for every test.
> 
> Sweet, this blows away my mess of shell scripts.  I've added this script
> to the test/ directory, thanks a lot for this.

We don't want to test the "remove" if "add" fails.

thanks,
Kay

[-- Attachment #2: 14-udev-test.pl-dont-test-remove-on-error.diff --]
[-- Type: text/plain, Size: 300 bytes --]

--- ../../udev/test/udev-test.pl	2003-11-24 01:23:25.000000000 +0100
+++ udev-test.pl	2003-11-24 02:17:01.000000000 +0100
@@ -151,7 +151,7 @@
 		system("tree $udev_root");
 		print "\n";
 		$error++;
-#		next;
+		next;
 	}
 
 	udev("remove", $config->{subsys}, $config->{devpath}, \$config->{conf});