linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Larson <kergoth@handhelds.org>
To: linux-hotplug@vger.kernel.org
Subject: [PATCH] Allow override of CFLAGS/LDFLAGS
Date: Mon, 24 Nov 2003 22:59:19 +0000	[thread overview]
Message-ID: <marc-linux-hotplug-106971527707016@msgid-missing> (raw)

[-- Attachment #1: Type: text/plain, Size: 683 bytes --]

Greetings,

As it is generally a good idea to allow the user to override CFLAGS and
LDFLAGS (automake based systems manage this with AM_CFLAGS vs CFLAGS),
here's a patch that does so.  The key is to keep options that are
required to build, along with include and link paths relative to the
source dir seperate from those that should be overridable (warning
flags, debug flags, optimizations, include/lib paths outside the source
tree).  Rather than adding another couple variables, I made use of the
GNU make 'override' directive.

--
Chris Larson - kergoth at handhelds dot org
Embedded Linux Developer - clarson at ti dot com
OpenZaurus Project Maintainer - http://openzaurus.org/

[-- Attachment #2: flags.patch --]
[-- Type: text/plain, Size: 1337 bytes --]


#
# Patch managed by http://www.mn-logistik.de/unsupported/pxa250/patcher
#

--- udev-007/Makefile~flags
+++ udev-007/Makefile
@@ -94,12 +94,13 @@
 endif
 
 # if DEBUG is enabled, then we do not strip or optimize
+override CFLAGS += -D_GNU_SOURCE
 ifeq ($(strip $(DEBUG)),true)
-	CFLAGS  += $(WARNINGS) -O1 -g -DDEBUG -D_GNU_SOURCE
+	CFLAGS  += $(WARNINGS) -O1 -g -DDEBUG
 	LDFLAGS += -Wl,-warn-common
 	STRIPCMD = /bin/true -Since_we_are_debugging
 else
-	CFLAGS  += $(WARNINGS) $(OPTIMIZATION) -fomit-frame-pointer -D_GNU_SOURCE
+	CFLAGS  += $(WARNINGS) $(OPTIMIZATION) -fomit-frame-pointer
 	LDFLAGS += -s -Wl,-warn-common
 	STRIPCMD = $(STRIP) -s --remove-section=.note --remove-section=.comment
 endif
@@ -118,15 +119,15 @@
 
 	CRT0 = $(KLIBC_DIR)/crt0.o
 	LIBC =	$(ARCH_LIB_OBJS) $(LIB_OBJS)
-	CFLAGS += -nostdinc -I$(INCLUDE_DIR) -I$(INCLUDE_DIR)/bits32 -I$(GCCINCDIR) -Iklibc/linux/include -D__KLIBC__
+	override CFLAGS += -nostdinc -I$(INCLUDE_DIR) -I$(INCLUDE_DIR)/bits32 -I$(GCCINCDIR) -Iklibc/linux/include -D__KLIBC__
 	LIB_OBJS =
-	LDFLAGS = --static --nostdlib -nostartfiles
+	override LDFLAGS += --static --nostdlib -nostartfiles
 else
 	CRT0 =
 	LIBC = 
-	CFLAGS += -I$(GCCINCDIR)
+	override CFLAGS += -I$(GCCINCDIR)
 	LIB_OBJS = -lc
-	LDFLAGS = --static 
+	override LDFLAGS += --static 
 endif
 
 all: $(LIBC) $(ROOT)

             reply	other threads:[~2003-11-24 22:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-24 22:59 Chris Larson [this message]
2003-12-02  0:42 ` [PATCH] Allow override of CFLAGS/LDFLAGS Greg KH
2003-12-02  1:33 ` Chris Larson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-hotplug-106971527707016@msgid-missing \
    --to=kergoth@handhelds.org \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).