From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Date: Tue, 25 Nov 2003 00:18:07 +0000 Subject: Re: Build failure - missing linux/limits.h include? Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-hotplug@vger.kernel.org On Tuesday 25 November 2003 00:12, Chris Larson wrote: > udev fails to compile here unless I'm doing a KLIBC build. =A0The reason > appears to be that the normal limits.h in the gcc inc dir doesn't pull > in linux/limits.h, whereas the limits.h out in the klibc include dirs > does. =A0I'd think it'd be best to add a #include to > udev.h directly, since it uses PATH_MAX. No, don't include kernel headers directly if you can avoid it. The problem you are referring to seems to be with old tool chains, I have the same symptom with my s390 gcc-2.95/glibc-2.1.3. Including instead of seems to fix it. Arnd <>< =3D=3D=3D udev.h 1.20 vs edited =3D=3D--- 1.20/udev.h Sun Nov 23 23:25:13 2= 003 +++ edited/udev.h Tue Nov 25 01:17:06 2003 @@ -24,7 +24,7 @@ #define UDEV_H =20 #include "libsysfs/libsysfs.h" -#include +#include =20 #ifdef DEBUG #include ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/ _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel