Re: udev does not create scsi disk entries during bootup

[Greg KH <greg@kroah.com>]

On Tue, Nov 25, 2003 at 06:14:12PM +0530, Surekha.PC wrote:
> 
> I am submitting the patch with 2 changes.

Can you split this up into 2 different patches, both generated with
'diff -u' so we can see the changes easier?

> 1)To include new field in the NUMBER rule specially for iSCSI devices.
>  
> The current rule provided by udev is as below.
> 
> NUMBER, BUS="scsi", ID=2:0:0:0", NAME="disk%n"
> 
> For iSCSI devices, since hostid is not consistent, we are defining a new
> iSCSI device attribute in sysfs, which will be checked while naming the
> device.
> 
> NUMBER, BUS="scsi", ID="0:0:0", device_type="ISCSI", NAME="ib0t0l0%n"

Where does the device_type come from?  Is it a sysfs file?

> 2) Device partition name needs to be appended with "s" before partition
> id.
>  
> If the device name consists of bus,target info like "c0b0t0l0" it will
> be easier to identify the partition as in "c0b0t0l0s1".

It looks like your patch just always adds a 's' whenever you use a %n
field.  Why not just put the 's' in your NAME?  Otherwise you just broke
everyone's rules who do not want a 's' :)

Can't you do everything you need with a simple callout script right now
with no changes needed for udev?

> Please find the patch alongwith.

patches are all that need to be sent.  You don't have to send the
original and modified files.

thanks,

greg k-h


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel