Re: [ANNOUNCE] udev 007 release

[Kay Sievers <kay.sievers@vrfy.org>]

[-- Attachment #1: Type: text/plain, Size: 721 bytes --]

On Mon, Dec 01, 2003 at 04:55:57PM -0800, Greg KH wrote:
> On Mon, Dec 01, 2003 at 11:51:19AM +0100, Marco d'Itri wrote:
> > On Nov 26, Greg KH <greg@kroah.com> wrote:

> >  >And then as your last REPLACE rule do:
> >  >	REPLACE, KERNEL="tty*", NAME="vc/%n"
> > I tried it, but it does not work. (And what about /dev/tty?)
> 
> Care to enable DEBUG_PARSE in namedev.c and send me the output when
> trying this?  Along with your config files.

Sorry, but we don't match against a wildcard now.
Please try the following patch:

01-catch--replace-device-by-wildcard.diff
  catch device name by wildcard to support a whole class of devices
  by just one config line like:
  REPLACE, KERNEL="tty*", NAME="vc/%n"


thanks,
Kay

[-- Attachment #2: 01-catch--replace-device-by-wildcard.diff --]
[-- Type: text/plain, Size: 944 bytes --]

diff -Nru a/namedev.c b/namedev.c
--- a/namedev.c	Tue Dec  2 16:03:35 2003
+++ b/namedev.c	Tue Dec  2 16:03:35 2003
@@ -860,8 +860,8 @@
 			continue;
 
 		dbg_parse("compare name '%s' with '%s'",
-			  dev->kernel_name, dev->name);
-		if (strcmp(dev->kernel_name, class_dev->name) != 0)
+			  dev->kernel_name, class_dev->name);
+		if (strncmp_wildcard(class_dev->name, dev->kernel_name, NAME_SIZE) != 0)
 			continue;
 
 		strfieldcpy(udev->name, dev->name);
diff -Nru a/test/udev-test.pl b/test/udev-test.pl
--- a/test/udev-test.pl	Tue Dec  2 16:03:35 2003
+++ b/test/udev-test.pl	Tue Dec  2 16:03:35 2003
@@ -51,6 +51,15 @@
 EOF
 	},
 	{
+		desc     => "catch device by wildcard",
+		subsys   => "tty",
+		devpath  => "class/tty/ttyUSB0",
+		expected => "visor/0" ,
+		conf     => <<EOF
+REPLACE, KERNEL="ttyUSB*", NAME="visor/%n"
+EOF
+	},
+	{
 		desc     => "replace kernel name",
 		subsys   => "tty",
 		devpath  => "class/tty/ttyUSB0",