[PATCH] switch hotplug scripts to use /bin/sh

[PATCH] switch hotplug scripts to use /bin/sh

[Martin Hicks]

[-- Attachment #1.1: Type: text/plain, Size: 300 bytes --]

Hi,

Is there any reason we can't make hotplug use /bin/sh instead of
/bin/bash?

Using /bin/bash breaks busybox, which doesn't know what to do when it is
called as /bin/bash.

Thanks,
mh

-- 
Martin Hicks                Wild Open Source Inc.
mort@wildopensource.com     613-266-2296


[-- Attachment #1.2: hotplug-bash-to-sh.diff --]
[-- Type: text/x-patch, Size: 4711 bytes --]

Index: dasd.agent
===================================================================
RCS file: /cvsroot/linux-hotplug/admin/etc/hotplug/dasd.agent,v
retrieving revision 1.1
diff -u -p -r1.1 dasd.agent
--- dasd.agent	7 Oct 2003 20:14:58 -0000	1.1
+++ dasd.agent	4 Dec 2003 14:43:57 -0000
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 #
 # Dasd hotplug policy agent for Linux 2.4 kernels
 #
Index: dasd.permissions
===================================================================
RCS file: /cvsroot/linux-hotplug/admin/etc/hotplug/dasd.permissions,v
retrieving revision 1.1
diff -u -p -r1.1 dasd.permissions
--- dasd.permissions	7 Oct 2003 20:14:58 -0000	1.1
+++ dasd.permissions	4 Dec 2003 14:43:57 -0000
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 #
 # Copyright (c) 2002 SuSE Linux AG, Nuremberg
 #
@@ -27,4 +27,4 @@ function dasd_permissions
 	*)
 	    die "dasd_permissions: don't know what permissions to give $NODE-$MAJOR-$MINOR-$MISC"
     esac
-}
\ No newline at end of file
+}
Index: ieee1394.agent
===================================================================
RCS file: /cvsroot/linux-hotplug/admin/etc/hotplug/ieee1394.agent,v
retrieving revision 1.10
diff -u -p -r1.10 ieee1394.agent
--- ieee1394.agent	16 Sep 2003 19:42:17 -0000	1.10
+++ ieee1394.agent	4 Dec 2003 14:43:57 -0000
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 #
 # IEEE1394-specific hotplug policy agent.
 #
Index: input.agent
===================================================================
RCS file: /cvsroot/linux-hotplug/admin/etc/hotplug/input.agent,v
retrieving revision 1.1
diff -u -p -r1.1 input.agent
--- input.agent	13 Oct 2003 23:52:54 -0000	1.1
+++ input.agent	4 Dec 2003 14:43:57 -0000
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 #
 # input-specific hotplug policy agent.
 #
Index: input.rc
===================================================================
RCS file: /cvsroot/linux-hotplug/admin/etc/hotplug/input.rc,v
retrieving revision 1.1
diff -u -p -r1.1 input.rc
--- input.rc	13 Oct 2003 23:52:54 -0000	1.1
+++ input.rc	4 Dec 2003 14:43:57 -0000
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 #
 # input.rc	This loads handlers for those input devices
 #		that have drivers compiled in kernel
Index: net.agent
===================================================================
RCS file: /cvsroot/linux-hotplug/admin/etc/hotplug/net.agent,v
retrieving revision 1.15
diff -u -p -r1.15 net.agent
--- net.agent	7 Oct 2003 19:56:24 -0000	1.15
+++ net.agent	4 Dec 2003 14:43:57 -0000
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 #
 # Network hotplug policy agent for Linux 2.4 kernels
 #
Index: pci.agent
===================================================================
RCS file: /cvsroot/linux-hotplug/admin/etc/hotplug/pci.agent,v
retrieving revision 1.13
diff -u -p -r1.13 pci.agent
--- pci.agent	16 Sep 2003 19:42:17 -0000	1.13
+++ pci.agent	4 Dec 2003 14:43:57 -0000
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 #
 # PCI-specific hotplug policy agent.
 #
Index: scsi.agent
===================================================================
RCS file: /cvsroot/linux-hotplug/admin/etc/hotplug/scsi.agent,v
retrieving revision 1.3
diff -u -p -r1.3 scsi.agent
--- scsi.agent	11 Dec 2002 22:05:06 -0000	1.3
+++ scsi.agent	4 Dec 2003 14:43:57 -0000
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 #
 # SCSI hotplug agent for 2.5 kernels 
 #
Index: tape.agent
===================================================================
RCS file: /cvsroot/linux-hotplug/admin/etc/hotplug/tape.agent,v
retrieving revision 1.1
diff -u -p -r1.1 tape.agent
--- tape.agent	7 Oct 2003 20:14:58 -0000	1.1
+++ tape.agent	4 Dec 2003 14:43:57 -0000
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 ###############################################################################
 # Tape hotplug agent for Linux 2.4 kernels
 #
Index: tape.permissions
===================================================================
RCS file: /cvsroot/linux-hotplug/admin/etc/hotplug/tape.permissions,v
retrieving revision 1.1
diff -u -p -r1.1 tape.permissions
--- tape.permissions	7 Oct 2003 20:14:58 -0000	1.1
+++ tape.permissions	4 Dec 2003 14:43:57 -0000
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 #
 # Copyright (c) 2002 IBM Development Germany, Boeblingen
 #
Index: usb.agent
===================================================================
RCS file: /cvsroot/linux-hotplug/admin/etc/hotplug/usb.agent,v
retrieving revision 1.35
diff -u -p -r1.35 usb.agent
--- usb.agent	13 Oct 2003 23:52:54 -0000	1.35
+++ usb.agent	4 Dec 2003 14:43:57 -0000
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 #
 # USB-specific hotplug policy agent.
 #

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] switch hotplug scripts to use /bin/sh

[Marco d'Itri]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

On Dec 04, Martin Hicks <mort@wildopensource.com> wrote:

 >Is there any reason we can't make hotplug use /bin/sh instead of
 >/bin/bash?
Yes, they use plenty of bashisms. OTOH Last week I sent to this mailing
list a patch which removes them, which is just waiting for an hotplug
maintainer to merge it.

-- 
ciao, |
Marco | [3466 co1mvGWx/HRRs]

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] switch hotplug scripts to use /bin/sh

[Martin Hicks]

On Thu, 2003-12-04 at 10:12, Marco d'Itri wrote:
> On Dec 04, Martin Hicks <mort@wildopensource.com> wrote:
> 
>  >Is there any reason we can't make hotplug use /bin/sh instead of
>  >/bin/bash?
> Yes, they use plenty of bashisms. OTOH Last week I sent to this mailing
> list a patch which removes them, which is just waiting for an hotplug
> maintainer to merge it.

Ah yes.  I do remember seeing those patches now.

Thanks for cleaning this up.
mh

-- 
Martin Hicks                Wild Open Source Inc.
mort@wildopensource.com     613-266-2296




-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills.  Sign up for IBM's
Free Linux Tutorials.  Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id\x1278&alloc_id371&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel