From mboxrd@z Thu Jan  1 00:00:00 1970
From: Martin Hicks <mort@bork.org>
Date: Mon, 08 Dec 2003 16:19:08 +0000
Subject: [PATCH] udev makefile broken when EXTRAS=""
MIME-Version: 1
Content-Type: multipart/mixed; boundary="=-bfV3s9GsFNgfxK0HEpxa"
Message-Id: <marc-linux-hotplug-107090041529720@msgid-missing>
List-Id: <linux-hotplug.vger.kernel.org>
To: linux-hotplug@vger.kernel.org


--=-bfV3s9GsFNgfxK0HEpxa
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Is anyone else seeing the makefile crap out when no EXTRAS are built?

I had to do the following to fix it.

--=20
Martin Hicks || mort@bork.org || PGP/GnuPG: 0x4C7F2BEE


# This is a BitKeeper generated patch for the following project:
# Project Name: udev
# This patch format is intended for GNU patch command version 2.5 or higher=
.
# This patch includes the following deltas:
#	           ChangeSet	1.271   -> 1.272 =20
#	            Makefile	1.48    -> 1.49  =20
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/12/08	mort@tomahawk.engr.sgi.com	1.272
# Fix Makefile to properly handle the case when EXTRAS is null.
# --------------------------------------------
#
diff -Nru a/Makefile b/Makefile
--- a/Makefile	Mon Dec  8 08:15:17 2003
+++ b/Makefile	Mon Dec  8 08:15:17 2003
@@ -139,11 +139,13 @@
 CFLAGS +=3D -I$(PWD)/libsysfs
=20
 all: $(ROOT)
-	@for target in $(EXTRAS) ; do \
-		echo $$target ; \
-		$(MAKE) prefix=3D$(prefix) LD=3D"$(LD)" SYSFS=3D"$(SYSFS)" \
-			-C $$target $@ ; \
-	done ; \
+	@if [ "$(EXTRAS)" !=3D "" ] ; then \
+		for target in "$(EXTRAS)" ; do \
+			echo $$target ; \
+			$(MAKE) prefix=3D$(prefix) LD=3D"$(LD)" SYSFS=3D"$(SYSFS)" \
+				-C $$target $@ ; \
+		done ; \
+	fi ; \
=20
 $(ROOT): $(LIBC)
=20
@@ -202,11 +204,13 @@
 	 | xargs rm -f=20
 	-rm -f core $(ROOT) $(GEN_HEADERS)
 	$(MAKE) -C klibc clean
-	@for target in $(EXTRAS) ; do \
-		echo $$target ; \
-		$(MAKE) prefix=3D$(prefix) LD=3D"$(LD)" SYSFS=3D"$(SYSFS)" \
-			-C $$target $@ ; \
-	done ; \
+	@if [ "$(EXTRAS)" !=3D "" ] ; then \
+		for target in "$(EXTRAS)" ; do \
+			echo $$target ; \
+			$(MAKE) prefix=3D$(prefix) LD=3D"$(LD)" SYSFS=3D"$(SYSFS)" \
+				-C $$target $@ ; \
+		done ; \
+	fi ; \
=20
 DISTFILES =3D $(shell find . \( -not -name '.' \) -print | grep -v CVS | g=
rep -v "\.tar\.gz" | grep -v "\/\." | grep -v releases | grep -v BitKeeper =
| grep -v SCCS | grep -v "\.tdb" | grep -v "test\/sys" | sort )
 DISTDIR :=3D $(RELEASE_NAME)
@@ -251,11 +255,13 @@
 	$(INSTALL_DATA) udev.permissions $(DESTDIR)$(configdir)
 	- rm -f $(DESTDIR)$(hotplugdir)/udev.hotplug
 	- ln -s $(sbindir)/$(ROOT) $(DESTDIR)$(hotplugdir)/udev.hotplug
-	@for target in $(EXTRAS) ; do \
-		echo $$target ; \
-		$(MAKE) prefix=3D$(prefix) LD=3D"$(LD)" SYSFS=3D"$(SYSFS)" \
-			-C $$target $@ ; \
-	done ; \
+	if [ "$(EXTRAS" !=3D "" ] ; then \
+		for target in "$(EXTRAS)" ; do \
+			echo $$target ; \
+			$(MAKE) prefix=3D$(prefix) LD=3D"$(LD)" SYSFS=3D"$(SYSFS)" \
+				-C $$target $@ ; \
+		done ; \
+	fi ; \
=20
 uninstall:
 	- rm $(hotplugdir)/udev.hotplug
@@ -267,10 +273,12 @@
 	- rmdir $(hotplugdir)
 	- rmdir $(configdir)
 	- rmdir $(udevdir)
-	@for target in $(EXTRAS) ; do \
-		echo $$target ; \
-		$(MAKE) prefix=3D$(prefix) LD=3D"$(LD)" SYSFS=3D"$(SYSFS)" \
-			-C $$target $@ ; \
-	done ; \
+	@if [ "$(EXTRAS)" !=3D "" ] ; then \
+		for target in "$(EXTRAS)" ; do \
+			echo $$target ; \
+			$(MAKE) prefix=3D$(prefix) LD=3D"$(LD)" SYSFS=3D"$(SYSFS)" \
+				-C $$target $@ ; \
+		done ; \
+	fi ; \
=20
=20


--=-bfV3s9GsFNgfxK0HEpxa
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/1KR80ZUZrUx/K+4RAielAJ4qtaNTeRqGvdeke93yuQu1U4K8qQCfVlv+
uT4OulNSUP+Hb6GptkeSwes=
=J7+G
-----END PGP SIGNATURE-----

--=-bfV3s9GsFNgfxK0HEpxa--



-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills.  Sign up for IBM's
Free Linux Tutorials.  Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel