From: Greg KH <greg@kroah.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: D-BUS patch for udev-008
Date: Mon, 08 Dec 2003 19:40:09 +0000 [thread overview]
Message-ID: <marc-linux-hotplug-107091285814763@msgid-missing> (raw)
In-Reply-To: <marc-linux-hotplug-107083813306826@msgid-missing>
On Mon, Dec 08, 2003 at 12:01:01AM +0100, David Zeuthen wrote:
> Hi,
>
> Attached is a patch against udev-008 to send out a D-BUS message when a
> device node is added or removed.
Very nice. I've applied your patch, and then made the following
changes:
- fixed the formatting to use tabs instead of spaces
- removed all of the #ifdef USE_DBUS statments out of the code
(I've been writing kernel code too long, #ifdef within .c
files looks ugly to me...) and created a new file udev_dbus.c
to hold these functions.
- changed the Makefile variable to DBUS instead of USE_DBUS
- turned the default option to not build the DBUS support as I
can't get it to link properly on a number of different OSs.
How did you test this? I get lots of errors at link time using a Fedora
1 machine. And I can't even build DBUS on an old Red Hat 7.3 box due to
automake issues :(
I've checked all of this into the bk tree if anyone else wants to play
with it.
thanks,
greg k-h
-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills. Sign up for IBM's
Free Linux Tutorials. Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id\x1278&alloc_id371&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next prev parent reply other threads:[~2003-12-08 19:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-07 23:01 D-BUS patch for udev-008 David Zeuthen
2003-12-08 0:34 ` Rob Love
2003-12-08 19:40 ` Greg KH [this message]
2003-12-08 20:11 ` David Zeuthen
2003-12-10 1:02 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-hotplug-107091285814763@msgid-missing \
--to=greg@kroah.com \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).