From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Tue, 16 Dec 2003 00:27:59 +0000 Subject: Re: [udev] don't rely on field order in namedev_parse Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Tue, Dec 16, 2003 at 01:21:58AM +0100, Kay Sievers wrote: > Yes, that's not nice. Two options come to my mind: > > o prepend SYSFS_ to the match, like: > LABEL, BUS="usb", SYSFS_model="Creative Labs WebCam*", NAME="video%n" > This is my favorite. It's close to the current and says clearly what it does. Yeah, I like this one too. > > > -#define TYPE_LABEL "LABEL" > > > -#define TYPE_NUMBER "NUMBER" > > > -#define TYPE_TOPOLOGY "TOPOLOGY" > > > -#define TYPE_REPLACE "REPLACE" > > > -#define TYPE_CALLOUT "CALLOUT" > > > > Why remove these? > > Oh I just wrote the code without it in mind and later simply removed it (being lazy). > The field name strings are also embedded in the code, > we may use #define's for the names of the fields too, then I'm happy :) Ok, that sounds good. thanks, greg k-h ------------------------------------------------------- This SF.net email is sponsored by: IBM Linux Tutorials. Become an expert in LINUX or just sharpen your skills. Sign up for IBM's Free Linux Tutorials. Learn everything from the bash shell to sys admin. Click now! http://ads.osdn.com/?ad_id78&alloc_id371&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel