From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Wed, 17 Dec 2003 18:34:06 +0000 Subject: Re: [PATCH] udev-009: Allow build with empty EXTRAS Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Wed, Dec 17, 2003 at 11:11:14AM -0500, Adam Kropelin wrote: > On Wed, Dec 17, 2003 at 12:31:00AM -0800, Greg KH wrote: > > On Tue, Dec 16, 2003 at 10:04:06PM -0500, Adam Kropelin wrote: > > > Need to let the shell expand $EXTRAS so it can properly detect an empty > > > list. Without this patch, the build fails whenever $EXTRAS is empty. > > > > $ export EXTRAS> > $ make > > $ set | grep EXTRA > > EXTRAS> > $ > > > > I can't duplicate this problem at all. Someone else once reported it on > > the linux-hotplug-devel list, with much the same fix up patch, but later > > said they couldn't reproduce it either. > > > > What version of make are you using? > > It's actually the version of bash that's important. Prior to 2.05a, bash > was unable to handle for loops with empty words lists. From the > bash-2.05a changelog: > > p. `for' loops now allow empty word lists after `in', like the > latest POSIX drafts require. > > So bash-2.05 dies on... > > for test in ; do echo $test ; done > > ...while bash-2.05a accepts it just fine. > > Both versions can handle this case if the shell itself does the > expansion that results in the empty list. So that's where my workaround > came from. Ah, ok, thanks for the explaination. I've applied this patch. greg k-h ------------------------------------------------------- This SF.net email is sponsored by: IBM Linux Tutorials. Become an expert in LINUX or just sharpen your skills. Sign up for IBM's Free Linux Tutorials. Learn everything from the bash shell to sys admin. Click now! http://ads.osdn.com/?ad_id78&alloc_id371&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel