* small parser fix
@ 2003-12-17 15:02 Marco d'Itri
2003-12-17 18:29 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Marco d'Itri @ 2003-12-17 15:02 UTC (permalink / raw)
To: linux-hotplug
[-- Attachment #1: Type: text/plain, Size: 223 bytes --]
The parser will complain if the rules file contains empty lines.
BTW, it's a real PITA udev exiting without an output or logging if a
single line in a config file cannot be parsed.
--
ciao, |
Marco | [3659 anKlt7WQ1y7rw]
[-- Attachment #2: fix_nl_rules --]
[-- Type: text/plain, Size: 387 bytes --]
diff -ruN udev-009.orig/namedev_parse.c udev-009/namedev_parse.c
--- udev-009.orig/namedev_parse.c 2003-12-16 03:26:49.000000000 +0100
+++ udev-009/namedev_parse.c 2003-12-17 15:52:20.000000000 +0100
@@ -159,7 +160,7 @@
dbg_parse("read '%s'", temp);
/* empty line? */
- if (*temp == 0x00)
+ if (*temp == 0x00 || *temp == '\n')
continue;
/* see if this is a comment */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: small parser fix
2003-12-17 15:02 small parser fix Marco d'Itri
@ 2003-12-17 18:29 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2003-12-17 18:29 UTC (permalink / raw)
To: linux-hotplug
On Wed, Dec 17, 2003 at 04:02:38PM +0100, Marco d'Itri wrote:
> The parser will complain if the rules file contains empty lines.
Thanks, I've fixed this with the other patch sent in.
> BTW, it's a real PITA udev exiting without an output or logging if a
> single line in a config file cannot be parsed.
What do you suggest we do? We log errors if debugging is enabled. Hm,
maybe we should return an error to userspace...
thanks,
greg k-h
-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills. Sign up for IBM's
Free Linux Tutorials. Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id\x1278&alloc_id371&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-12-17 18:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-12-17 15:02 small parser fix Marco d'Itri
2003-12-17 18:29 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).