Re: Possible udev bug and some questions

[Greg KH <greg@kroah.com>]

On Wed, Dec 24, 2003 at 04:19:14PM -0800, Greg KH wrote:
> On Thu, Dec 25, 2003 at 12:25:22AM +0200, Martin Schlemmer wrote:
> > Hi
> > 
> > I know its not good form to post so many issues in one, but I
> > am currently on dialup, and not for more than a few hours.  Also
> > please CC me, as I am not on this list.
> > 
> > 1) if you look at the following code in namedev.c (in
> >  function do_callout()):
> > 
> > --
> >                 if (sysfs_device) {
> >                         dbg("dev->bus='%s' sysfs_device->bus='%s'",
> > dev->bus, sysfs_device->bus);
> >                         if (strcasecmp(dev->bus, sysfs_device->bus) !> > 0)
> >                                 continue;
> > 
> >                 }
> > --
> > 
> > there is a slight problem - if sysfs_device = NULL, then the
> > 'strcasecmp(dev->bus, sysfs_device->bus) != 0' test will never
> > be evaluated, and result in the callout to run for all non-phisical (?)
> > devices.
> 
> Ah, good catch.  I've put a test in the udev-test.pl script to catch
> this bug, and added the following patch:

I made the same patch for the LABEL rule, as that also could trigger
wrong acceptances.

thanks again.

greg k-h


-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills.  Sign up for IBM's
Free Linux Tutorials.  Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id\x1278&alloc_id371&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel