Bug in USB Generic Serial driver

[Greg KH <greg@kroah.com>]

Hi all,

It seems that the last round of hotplug changes broke a few more things.
If you load (or compile in) the USB Generic Serial driver, it will
_always_ grab any device that it is offered, if the user does not
specify a product and vendor id for it on the 'insmod' command line.

This is because its vendor and product id are set to 0 initially, with
_no_ match_flags setting either.  In the function, usb_match_id, a value
of 0 means accept any as a wild card.

So to fix this, either the Generic Serial driver can change its default
values to something like 0xffff for both the vendor and product id, or
we can change the usb_match_id function somehow, or something else?

I thought that the usb scanner driver would also have this problem, but
it looks like the ability to specify the vendor and product ids as a
module load parameter have been removed.

And I also don't like the ordering specificness of the new USB_DEVICE
macro, and liked the named initializers better, but can't think of a
better way to do it right this second.

Comments?

Thanks Randy, for pointing this problem out to me.

greg k-h


-- 
greg@(kroah|wirex).com

_______________________________________________
Linux-hotplug-devel mailing list
Linux-hotplug-devel@lists.sourceforge.net
http://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel