Small patch for hotplug scripts, success story

Small patch for hotplug scripts, success story

[Norbert Preining]

Hi there!

Small success story after fixing one problem:

linux-2.4.0-final + modutils/hotplug patch
modutils-2.4.1

hotplugging works IF:

* usbmodules is removed: It gives NOTHING! at the moment, at least for
	my devices
* fix in hotplug.function:
	LISTER=`which ${1}modules 2>/dev/null`
  unfortunately if which is /usr/bin/which we get
	LISTER="which: no usbmodules in ...."
  because /usr/bin/which don't write this message to stderr, but stdout.
  Therefor no internal scanning is done and nothing works.
  Better would be
	LISTER=`type -p ${1}modules`
  since these scripts are bash and `type' is a buildin.

But after these two changes (remove usbmodules and fix which<->type -p) it
is working!

Best wishes


Norbert

-- 
ciao
norb

+-------------------------------------------------------------------+
| Norbert Preining              http://www.logic.at/people/preining |
| University of Technology Vienna, Austria        preining@logic.at |
| DSA: 0x09C5B094 (RSA: 0xCF1FA165) mail subject: get [DSA|RSA]-key |
+-------------------------------------------------------------------+

_______________________________________________
Linux-hotplug-devel mailing list
Linux-hotplug-devel@lists.sourceforge.net
http://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: Small patch for hotplug scripts, success story

[David Brownell]

Hi Norbert,

> linux-2.4.0-final + modutils/hotplug patch
> modutils-2.4.1
> 
> hotplugging works IF:
> 
> * usbmodules is removed: It gives NOTHING! at the moment, at least for
> my devices

Right -- the current version won't understand the 2.4.1 modutils
output, but then its standard install isn't in the path that the
hotplug scripts use.


> * fix in hotplug.function:
> LISTER=`which ${1}modules 2>/dev/null`
>   unfortunately if which is /usr/bin/which we get
> LISTER="which: no usbmodules in ...."
>   because /usr/bin/which don't write this message to stderr, but stdout.
>   Therefor no internal scanning is done and nothing works.

Curious.  I didn't see that, but then maybe I'm running with
a "which" command that doesn't have that bug.


>   Better would be
> LISTER=`type -p ${1}modules`
>   since these scripts are bash and `type' is a buildin.

Sounds good!  The fix is now in CVS (at linux-usb for now).


> But after these two changes (remove usbmodules and fix which<->type -p) it
> is working!

Great!  Thanks for the confirmation.

- Dave




_______________________________________________
Linux-hotplug-devel mailing list
Linux-hotplug-devel@lists.sourceforge.net
http://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel