Re: Hotunplug

[Greg KH <greg@kroah.com>]

On Tue, May 22, 2001 at 05:44:45PM -0700, Stephen Williams wrote:
> 
> I've made a go at implementing support for hot unplug in the hotplug
> scripts. What I have done is calculated a path to a "remover" program
> that is passed as the REMOVE environment variable to the existing add
> scripts. If the add script wants to make something happen when the
> device is removed, it writes something to the remover and marks it
> executable.

I like the idea of this, but the following lines make me nervous:

 
+    # Create a directory to hold remover programs. Close it up so
+    # that only hotplug scripts can write to this directory.
+    mkdir /var/run/usb
+    chmod 0700 /var/run/usb
+

Things like this should be done by the installer of the package, so as
to allow different distros handle this properly.

Also, the creation of directories should be done only once, not every
time.

If David doesn't object, I'll add this patch to cvs (without the above
change, but with the .spec file changed.)

thanks,

greg k-h

_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
http://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel