* Re: [PATCH] udev: sync udev rules directories with systemd units directories
From: Marco d'Itri @ 2012-07-14 3:46 UTC (permalink / raw)
To: linux-hotplug
In-Reply-To: <1342214503-7931-1-git-send-email-w.d.hubbs@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 519 bytes --]
On Jul 14, William Hubbs <w.d.hubbs@gmail.com> wrote:
> /usr/lib/udev/rules.d. The reason is not because of udev, but other
> packages which install their rules in /lib/udev/rules.d need to be fixed
> to install them in /usr/lib/udev/rules.d.
As the maintainer of udev for a distribution which still supports a
standalone /usr I fail to see how this can be an issue.
Why should an upstream package install something in
/usr/lib/udev/rules.d/ if no distribution supports this directory?
--
ciao,
Marco
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* Re: [PATCH] udev: sync udev rules directories with systemd units directories
From: William Hubbs @ 2012-07-14 5:42 UTC (permalink / raw)
To: linux-hotplug
In-Reply-To: <1342214503-7931-1-git-send-email-w.d.hubbs@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]
On Sat, Jul 14, 2012 at 05:46:56AM +0200, Marco d'Itri wrote:
> On Jul 14, William Hubbs <w.d.hubbs@gmail.com> wrote:
>
> > /usr/lib/udev/rules.d. The reason is not because of udev, but other
> > packages which install their rules in /lib/udev/rules.d need to be fixed
> > to install them in /usr/lib/udev/rules.d.
> As the maintainer of udev for a distribution which still supports a
> standalone /usr I fail to see how this can be an issue.
> Why should an upstream package install something in
> /usr/lib/udev/rules.d/ if no distribution supports this directory?
I'm not sure if you are asking me or Kay, but here is what we are
running into.
The default configuration of udev-186 installs its rules in
/usr/lib/udev/rules.d. When users upgrade to this udev, they will still
have packages on their system that install rules in /lib/udev/rules.d.
Udev needs to keep this directory as a place for rules for a while for
that reason.
With the /usr merge coming, I'm thinking that packages that install
rules in /lib/udev/rules.d will have to be fixed to install them in
/usr/lib/udev/rules.d eventually, but until then, we should retain
support in udev to read from both places.
Thoughts?
William
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* Re: [PATCH] udev: sync udev rules directories with systemd units directories
From: Marco d'Itri @ 2012-07-14 5:52 UTC (permalink / raw)
To: linux-hotplug
In-Reply-To: <1342214503-7931-1-git-send-email-w.d.hubbs@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
On Jul 14, William Hubbs <w.d.hubbs@gmail.com> wrote:
> With the /usr merge coming, I'm thinking that packages that install
> rules in /lib/udev/rules.d will have to be fixed to install them in
> /usr/lib/udev/rules.d eventually, but until then, we should retain
> support in udev to read from both places.
>
> Thoughts?
Now I see the your point. I need to think a bit about the best
solution for the transition period, but right now I suspect that it
will be a /usr/lib/udev/rules.d/ to /lib/udev/rules.d/ symlink.
(My problem is that I need to think when the symlink should be created
and removed to support the merge, distributions which do not support
upgrades do not need to care about this detail...)
--
ciao,
Marco
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* Re: [PATCH] udev: sync udev rules directories with systemd units directories
From: William Hubbs @ 2012-07-14 7:21 UTC (permalink / raw)
To: linux-hotplug
In-Reply-To: <1342214503-7931-1-git-send-email-w.d.hubbs@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1381 bytes --]
On Sat, Jul 14, 2012 at 07:52:23AM +0200, Marco d'Itri wrote:
> On Jul 14, William Hubbs <w.d.hubbs@gmail.com> wrote:
>
> > With the /usr merge coming, I'm thinking that packages that install
> > rules in /lib/udev/rules.d will have to be fixed to install them in
> > /usr/lib/udev/rules.d eventually, but until then, we should retain
> > support in udev to read from both places.
> >
> > Thoughts?
> Now I see the your point. I need to think a bit about the best
> solution for the transition period, but right now I suspect that it
> will be a /usr/lib/udev/rules.d/ to /lib/udev/rules.d/ symlink.
>
> (My problem is that I need to think when the symlink should be created
> and removed to support the merge, distributions which do not support
> upgrades do not need to care about this detail...)
I don't follow how a symlink either
/usr/lib/udev/rules.d->/lib/udev/rules.d or the other way around is
going to make the transition work smoothly for us. If we support both
locations as directories, once all of the packages that still install
things in /lib/udev/rules.d give us a way in their upstreams to install
the rules under /usr, /lib/udev/rules.d will just naturally disappear
from everyone's systems.
How is linking /usr/lib/udev/rules.d to /lib/udev/rules.d going to aid
in the transition? That seems to be going backward.
William
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* Re: [PATCH] udev: sync udev rules directories with systemd units directories
From: Martin Pitt @ 2012-07-15 17:03 UTC (permalink / raw)
To: linux-hotplug
In-Reply-To: <1342214503-7931-1-git-send-email-w.d.hubbs@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 976 bytes --]
Hello Marco,
Marco d'Itri [2012-07-14 7:52 +0200]:
> Now I see the your point. I need to think a bit about the best
> solution for the transition period, but right now I suspect that it
> will be a /usr/lib/udev/rules.d/ to /lib/udev/rules.d/ symlink.
FWIW, this seems like the best solution to me. In Debian we don't want
packages (which are under our control) nor third-party packages (which
would be covered by the symlink) to install udev rules (or binaries)
under /usr, as (as far as I understand) Debian still wants to support
a standalone /usr.
I take it the Debian udev/systemd package would not change the layout?
I. e. still install most things under /lib?
> (My problem is that I need to think when the symlink should be created
> and removed to support the merge
Which merge?
Thanks,
Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply
* Re: [PATCH] udev: sync udev rules directories with systemd units directories
From: Marco d'Itri @ 2012-07-15 17:14 UTC (permalink / raw)
To: linux-hotplug
In-Reply-To: <1342214503-7931-1-git-send-email-w.d.hubbs@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 455 bytes --]
On Jul 15, Martin Pitt <martin.pitt@ubuntu.com> wrote:
> I take it the Debian udev/systemd package would not change the layout?
> I. e. still install most things under /lib?
Indeed.
> > (My problem is that I need to think when the symlink should be created
> > and removed to support the merge
> Which merge?
The "everything in /usr" merge, which I plan to propose after the
release. Does Ubuntu have plans about this?
--
ciao,
Marco
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* Re: [PATCH] udev: sync udev rules directories with systemd units directories
From: Martin Pitt @ 2012-07-15 17:45 UTC (permalink / raw)
To: linux-hotplug
In-Reply-To: <1342214503-7931-1-git-send-email-w.d.hubbs@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 664 bytes --]
Marco d'Itri [2012-07-15 19:14 +0200]:
> > Which merge?
> The "everything in /usr" merge, which I plan to propose after the
> release. Does Ubuntu have plans about this?
No, we don't. We do support a separate /usr (just like Debian), but
quite frankly this is an issue which is of little interest on the
areas Ubuntu is concerned with, so on the the Ubuntu side we won't
spend any work on on this subject, one way or the other. I. e. we'll
continue to support separate /usr for as long as Debian does.
Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply
* Re: [PATCH] udev: sync udev rules directories with systemd units directories
From: William Hubbs @ 2012-07-15 23:09 UTC (permalink / raw)
To: linux-hotplug
In-Reply-To: <1342214503-7931-1-git-send-email-w.d.hubbs@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 841 bytes --]
On Sun, Jul 15, 2012 at 07:14:02PM +0200, Marco d'Itri wrote:
> On Jul 15, Martin Pitt <martin.pitt@ubuntu.com> wrote:
>
> > I take it the Debian udev/systemd package would not change the layout?
> > I. e. still install most things under /lib?
> Indeed.
>
> > > (My problem is that I need to think when the symlink should be created
> > > and removed to support the merge
> > Which merge?
> The "everything in /usr" merge, which I plan to propose after the
> release. Does Ubuntu have plans about this?
That's the problem with a symlink, either way. How do you know when to
create or remove it?
For us, I would have to do the following on every user's system a udev upgrade:
cp -a /lib/udev /usr/lib/udev
ln -s /usr/lib/udev /lib/udev
Then, I have no idea how I would know when to remove the link.
William
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* Re: [PATCH] udev: sync udev rules directories with systemd units directories
From: Kay Sievers @ 2012-07-16 0:02 UTC (permalink / raw)
To: linux-hotplug
In-Reply-To: <1342214503-7931-1-git-send-email-w.d.hubbs@gmail.com>
On Mon, Jul 16, 2012 at 1:09 AM, William Hubbs <w.d.hubbs@gmail.com> wrote:
> On Sun, Jul 15, 2012 at 07:14:02PM +0200, Marco d'Itri wrote:
>> On Jul 15, Martin Pitt <martin.pitt@ubuntu.com> wrote:
>>
>> > I take it the Debian udev/systemd package would not change the layout?
>> > I. e. still install most things under /lib?
>> Indeed.
>>
>> > > (My problem is that I need to think when the symlink should be created
>> > > and removed to support the merge
>> > Which merge?
>> The "everything in /usr" merge, which I plan to propose after the
>> release. Does Ubuntu have plans about this?
>
> That's the problem with a symlink, either way. How do you know when to
> create or remove it?
>
> For us, I would have to do the following on every user's system a udev upgrade:
>
> cp -a /lib/udev /usr/lib/udev
> ln -s /usr/lib/udev /lib/udev
>
> Then, I have no idea how I would know when to remove the link.
Which is why you don't do such a mess.
You keep the historic split as long as it works (some day it will
break step-by-step in non-interesting ways because upstream projects
don't care or test a anymore), or you convert /bin, /sbin, /lib,
/lib64 _one_ go to symlinks.
The conversion of the top-level dirs to symlinks is almost trivial. We
did it in Fedora with no interesting problems at all.
http://people.freedesktop.org/~kay/usrmove-convert-log.png
http://people.freedesktop.org/~kay/usrmove-convert-log.txt
Doing what you try to do here, with creating a total mess with stuff
randomly spread around the filesystem is just plain crazy. We do not
really support that in any tool, and honestly the --enable-split-usr
configure option you added to systemd should just be removed. We do
not support that mess, and it makes no sense to even try. That should
be a distro patch, that makes it clear that you are completely on your
own here.
Better get your stuff together and make decision, by either doing
nothing for now, leaving the stuff in /lib, or by really doing it and
make /lib a symlink. There is no sane option to choose from doing only
a part of it, or gradual, it's just madness.
Kay
^ permalink raw reply
* Re: [PATCH] udev: sync udev rules directories with systemd units directories
From: Marco d'Itri @ 2012-07-16 0:06 UTC (permalink / raw)
To: linux-hotplug
In-Reply-To: <1342214503-7931-1-git-send-email-w.d.hubbs@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 565 bytes --]
On Jul 16, William Hubbs <w.d.hubbs@gmail.com> wrote:
> That's the problem with a symlink, either way. How do you know when to
> create or remove it?
This is a general problem for every package which ships the same file in
/ and /usr, I fear that the only solution will be to create the link
in postinst if needed.
On Jul 16, Kay Sievers <kay@vrfy.org> wrote:
> The conversion of the top-level dirs to symlinks is almost trivial. We
Except for patching tens of packages which ship the a file with the
same name in / and /usr.
--
ciao,
Marco
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* Re: [PATCH] udev: sync udev rules directories with systemd units directories
From: Kay Sievers @ 2012-07-16 0:26 UTC (permalink / raw)
To: linux-hotplug
In-Reply-To: <1342214503-7931-1-git-send-email-w.d.hubbs@gmail.com>
On Mon, Jul 16, 2012 at 2:06 AM, Marco d'Itri <md@linux.it> wrote:
> On Jul 16, Kay Sievers <kay@vrfy.org> wrote:
>
>> The conversion of the top-level dirs to symlinks is almost trivial. We
> Except for patching tens of packages which ship the a file with the
> same name in / and /usr.
Which was ~25 for Fedora, which is: nothing.
Then it might be ~75 for Debian, and that can still be fixed in one
single day, if wanted to.
Kay
^ permalink raw reply
* Re: [PATCH] udev: sync udev rules directories with systemd units directories
From: William Hubbs @ 2012-07-17 0:57 UTC (permalink / raw)
To: linux-hotplug
In-Reply-To: <1342214503-7931-1-git-send-email-w.d.hubbs@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]
On Mon, Jul 16, 2012 at 02:26:26AM +0200, Kay Sievers wrote:
> On Mon, Jul 16, 2012 at 2:06 AM, Marco d'Itri <md@linux.it> wrote:
> > On Jul 16, Kay Sievers <kay@vrfy.org> wrote:
> >
> >> The conversion of the top-level dirs to symlinks is almost trivial. We
> > Except for patching tens of packages which ship the a file with the
> > same name in / and /usr.
>
> Which was ~25 for Fedora, which is: nothing.
>
> Then it might be ~75 for Debian, and that can still be fixed in one
> single day, if wanted to.
Then there are things like what we did in gentoo years before I came on
board to get around a toolchain bug https://bugs.gentoo.org/4411.
Whoever was working on this back then decided that we should move most
of the critical shared libraries to /lib or /lib64 and put linker
scripts in /usr/lib*. That has to disappear before we can even think
about the /usr merge.
Also, remember that we are a rolling release distro. We do not have
specific gentoo x.x releases; users just go along updating packages. So,
I'm not sure how to force the /usr merge and symlink creation to happen
on all of our users' systems in one go.
William
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* Re: [PATCH] udev: sync udev rules directories with systemd units directories
From: William Hubbs @ 2012-07-17 1:14 UTC (permalink / raw)
To: linux-hotplug
In-Reply-To: <1342214503-7931-1-git-send-email-w.d.hubbs@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 397 bytes --]
I need to try to make the issue for us a bit more clear.
Basically gentoo does not have fixed releases, and we support in-place
upgrades of packages. So if udev changes in a way that does not retain
backward compatibility for a while, it will cause breakage for us.
This is why we are asking that you continue supporting rules in
/lib/udev for a while.
Thanks for your consideration,
William
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* Re: [PATCH] udev: sync udev rules directories with systemd units directories
From: Lucas De Marchi @ 2012-07-17 7:03 UTC (permalink / raw)
To: linux-hotplug
In-Reply-To: <1342214503-7931-1-git-send-email-w.d.hubbs@gmail.com>
Hi William,
On Mon, Jul 16, 2012 at 9:57 PM, William Hubbs <w.d.hubbs@gmail.com> wrote:
> On Mon, Jul 16, 2012 at 02:26:26AM +0200, Kay Sievers wrote:
>> On Mon, Jul 16, 2012 at 2:06 AM, Marco d'Itri <md@linux.it> wrote:
>> > On Jul 16, Kay Sievers <kay@vrfy.org> wrote:
>> >
>> >> The conversion of the top-level dirs to symlinks is almost trivial. We
>> > Except for patching tens of packages which ship the a file with the
>> > same name in / and /usr.
>>
>> Which was ~25 for Fedora, which is: nothing.
>>
>> Then it might be ~75 for Debian, and that can still be fixed in one
>> single day, if wanted to.
>
> Then there are things like what we did in gentoo years before I came on
> board to get around a toolchain bug https://bugs.gentoo.org/4411.
>
> Whoever was working on this back then decided that we should move most
> of the critical shared libraries to /lib or /lib64 and put linker
> scripts in /usr/lib*. That has to disappear before we can even think
> about the /usr merge.
>
> Also, remember that we are a rolling release distro. We do not have
> specific gentoo x.x releases; users just go along updating packages. So,
> I'm not sure how to force the /usr merge and symlink creation to happen
> on all of our users' systems in one go.
Talk to Dave and Tom (CC'ed) . Archlinux is a rolling distro as welll,
and they managed to get it working.
Lucas De Marchi
^ permalink raw reply
* Re: [PATCH] udev: sync udev rules directories with systemd units directories
From: Tom Gundersen @ 2012-07-17 11:46 UTC (permalink / raw)
To: linux-hotplug
In-Reply-To: <1342214503-7931-1-git-send-email-w.d.hubbs@gmail.com>
On Tue, Jul 17, 2012 at 2:57 AM, William Hubbs <w.d.hubbs@gmail.com> wrote:
> Whoever was working on this back then decided that we should move most
> of the critical shared libraries to /lib or /lib64 and put linker
> scripts in /usr/lib*. That has to disappear before we can even think
> about the /usr merge.
>
> Also, remember that we are a rolling release distro. We do not have
> specific gentoo x.x releases; users just go along updating packages. So,
> I'm not sure how to force the /usr merge and symlink creation to happen
> on all of our users' systems in one go.
We had a similar issue in Arch. What we did was the following:
Patch udev+kmod+systemd (the last one was for free) to read from
{/usr,}/lib/{modprobe.d,depmod.d,udev/rules.d,systemd/system}.
We then rebuild all the packages that installed binaries to /lib/udev/
and /lib/systemd to move them to their /usr/lib counterparts (as we
did not want to patch udev/systemd to read the helpers from more than
one location).
Then we let people rebuild their packages to move things from /lib to
/usr/lib on a package-by-package basis.
Then we rebuilt all our kernels and pointed kmod/udev to
/usr/lib/modules rather than /lib/modules.
At this point only glibc owned stuff in /lib, so we rebuilt that to
move it all to /usr/lib and replace /lib with a symlink to /usr/lib.
The only step that caused any issues was the last one, and that was
due to users ignoring the upgrade instructions[0] and doing clever
things like "rm -rf /lib".
HTH,
Tom
[0]: <http://www.archlinux.org/news/the-lib-directory-becomes-a-symlink/>
^ permalink raw reply
* Re: [PATCH] udev: sync udev rules directories with systemd units directories
From: William Hubbs @ 2012-07-17 23:44 UTC (permalink / raw)
To: linux-hotplug
In-Reply-To: <1342214503-7931-1-git-send-email-w.d.hubbs@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]
On Tue, Jul 17, 2012 at 01:46:17PM +0200, Tom Gundersen wrote:
> We had a similar issue in Arch. What we did was the following:
>
> Patch udev+kmod+systemd (the last one was for free) to read from
> {/usr,}/lib/{modprobe.d,depmod.d,udev/rules.d,systemd/system}.
>
> We then rebuild all the packages that installed binaries to /lib/udev/
> and /lib/systemd to move them to their /usr/lib counterparts (as we
> did not want to patch udev/systemd to read the helpers from more than
> one location).
>
> Then we let people rebuild their packages to move things from /lib to
> /usr/lib on a package-by-package basis.
>
> Then we rebuilt all our kernels and pointed kmod/udev to
> /usr/lib/modules rather than /lib/modules.
>
> At this point only glibc owned stuff in /lib, so we rebuilt that to
> move it all to /usr/lib and replace /lib with a symlink to /usr/lib.
The problem for us with these steps is that the building happens on
users' systems since we are source based, so we have to go about it
differently. We can't rebuild packages and send them down to the users.
This is why it would be very helpful if udev would keep some backward
compatibility and read rules from /lib/udev/rules.d as long as it was a
directory.
Thanks for consideration,
William
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* Re: [PATCH] udev: sync udev rules directories with systemd units directories
From: Greg KH @ 2012-07-17 23:50 UTC (permalink / raw)
To: linux-hotplug
In-Reply-To: <1342214503-7931-1-git-send-email-w.d.hubbs@gmail.com>
On Tue, Jul 17, 2012 at 06:44:00PM -0500, William Hubbs wrote:
> On Tue, Jul 17, 2012 at 01:46:17PM +0200, Tom Gundersen wrote:
> > We had a similar issue in Arch. What we did was the following:
> >
> > Patch udev+kmod+systemd (the last one was for free) to read from
> > {/usr,}/lib/{modprobe.d,depmod.d,udev/rules.d,systemd/system}.
> >
> > We then rebuild all the packages that installed binaries to /lib/udev/
> > and /lib/systemd to move them to their /usr/lib counterparts (as we
> > did not want to patch udev/systemd to read the helpers from more than
> > one location).
> >
> > Then we let people rebuild their packages to move things from /lib to
> > /usr/lib on a package-by-package basis.
> >
> > Then we rebuilt all our kernels and pointed kmod/udev to
> > /usr/lib/modules rather than /lib/modules.
> >
> > At this point only glibc owned stuff in /lib, so we rebuilt that to
> > move it all to /usr/lib and replace /lib with a symlink to /usr/lib.
>
> The problem for us with these steps is that the building happens on
> users' systems since we are source based, so we have to go about it
> differently. We can't rebuild packages and send them down to the users.
No, but we can fix all packages in the tree, and then update the udev
version, with a big fat warning / error when we install the new udev
package saying that the rules need to be fixed by updating the packages
that placed them there.
> This is why it would be very helpful if udev would keep some backward
> compatibility and read rules from /lib/udev/rules.d as long as it was a
> directory.
I don't think this is really necessary, as long as we just fix up all
packages in the tree that are doing things wrong. That shouldn't take
very long (hint, if you need help, I'll be glad to do so.)
thanks,
greg k-h
^ permalink raw reply
* Re: [PATCH] udev: sync udev rules directories with systemd units directories
From: William Hubbs @ 2012-07-18 6:02 UTC (permalink / raw)
To: linux-hotplug
In-Reply-To: <1342214503-7931-1-git-send-email-w.d.hubbs@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2070 bytes --]
On Tue, Jul 17, 2012 at 04:50:48PM -0700, greg wrote:
> On Tue, Jul 17, 2012 at 06:44:00PM -0500, William Hubbs wrote:
> > On Tue, Jul 17, 2012 at 01:46:17PM +0200, Tom Gundersen wrote:
> > > We had a similar issue in Arch. What we did was the following:
> > >
> > > Patch udev+kmod+systemd (the last one was for free) to read from
> > > {/usr,}/lib/{modprobe.d,depmod.d,udev/rules.d,systemd/system}.
> > >
> > > We then rebuild all the packages that installed binaries to /lib/udev/
> > > and /lib/systemd to move them to their /usr/lib counterparts (as we
> > > did not want to patch udev/systemd to read the helpers from more than
> > > one location).
> > >
> > > Then we let people rebuild their packages to move things from /lib to
> > > /usr/lib on a package-by-package basis.
> > >
> > > Then we rebuilt all our kernels and pointed kmod/udev to
> > > /usr/lib/modules rather than /lib/modules.
> > >
> > > At this point only glibc owned stuff in /lib, so we rebuilt that to
> > > move it all to /usr/lib and replace /lib with a symlink to /usr/lib.
> >
> > The problem for us with these steps is that the building happens on
> > users' systems since we are source based, so we have to go about it
> > differently. We can't rebuild packages and send them down to the users.
>
> No, but we can fix all packages in the tree, and then update the udev
> version, with a big fat warning / error when we install the new udev
> package saying that the rules need to be fixed by updating the packages
> that placed them there.
>
> > This is why it would be very helpful if udev would keep some backward
> > compatibility and read rules from /lib/udev/rules.d as long as it was a
> > directory.
>
> I don't think this is really necessary, as long as we just fix up all
> packages in the tree that are doing things wrong. That shouldn't take
> very long (hint, if you need help, I'll be glad to do so.)
Hey greg,
write to me off list and let me know what we need to do and we can go
from there.
Thanks,
William
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* udev-171-r6 test failed
From: Happy Penguin Computers support @ 2012-07-22 5:16 UTC (permalink / raw)
To: linux-hotplug
coolermaster ~ # USE="-test" emerge -avjt sys-fs/udev
These are the packages that would be merged, in reverse order:
Calculating dependencies... done!
[ebuild R ] sys-fs/udev-171-r6 USE="rule_generator test* -action_modeswitch -build -debug -edd -extras -floppy -gudev -hwdb -introspection -keymap (-selinux)" 0 kB
Total: 1 package (1 reinstall), Size of downloads: 0 kB
Would you like to merge these packages? [Yes/No] Yes
>>> Verifying ebuild manifests
>>> Emerging (1 of 1) sys-fs/udev-171-r6
>>> Failed to emerge sys-fs/udev-171-r6, Log file:
>>> '/home/mingdao/portage_logs/build/sys-fs/udev-171-r6:20120722-051032.log'
>>> Jobs: 0 of 1 complete, 1 failed Load avg: 0.94, 0.21, 0.27
* Package: sys-fs/udev-171-r6
* Repository: gentoo
* Maintainer: udev-bugs@gentoo.org
* USE: amd64 elibc_glibc kernel_linux multilib rule_generator test userland_GNU
* FEATURES: sandbox test userpriv usersandbox
* Determining the location of the kernel source code
* Found kernel source directory:
* /usr/src/linux
* Found kernel object directory:
* /lib/modules/3.3.8/build
* Found sources for kernel version:
* 3.3.8
* Checking for suitable kernel configuration options...
[ ok ]
*
* udev-171 does not support Linux kernel before version 2.6.32!
* Your kernel version (3.3.8) is new enough to run udev-171 reliably.
* Determining the location of the kernel source code
* Found kernel source directory:
* /usr/src/linux-3.3.8
* Found kernel object directory:
* /lib/modules/3.3.8/build
* Found sources for kernel version:
* 3.3.8
>>> Unpacking source...
>>> Unpacking udev-171.tar.bz2 to /var/tmp/portage/sys-fs/udev-171-r6/work
>>> Unpacking udev-171-testsys.tar.bz2 to /var/tmp/portage/sys-fs/udev-171-r6/work
>>> Unpacking udev-171-gentoo-patchset-v1.tar.bz2 to /var/tmp/portage/sys-fs/udev-171-r6/work
>>> Unpacking udev-gentoo-scripts-7.tar.bz2 to /var/tmp/portage/sys-fs/udev-171-r6/work
>>> Source unpacked in /var/tmp/portage/sys-fs/udev-171-r6/work
>>> Preparing source in /var/tmp/portage/sys-fs/udev-171-r6/work/udev-171 ...
* Applying various patches (bugfixes/updates) ...
* 0001-Revert-udevd-log-warning-if-run-is-not-writable.patch ...
[ ok ]
* Done with patching
* Running elibtoolize in: udev-171/
* Applying portage/1.2.0 patch ...
* Applying sed/1.5.6 patch ...
* Applying as-needed/2.2.6 patch ...
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/sys-fs/udev-171-r6/work/udev-171 ...
* econf: updating udev-171/config.sub with /usr/share/gnuconfig/config.sub
* econf: updating udev-171/config.guess with /usr/share/gnuconfig/config.guess
./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --disable-dependency-tracking --prefix=/usr --sysconfdir=/etc --sbindir=/sbin --libdir=/usr/lib64 --with-rootlibdir=/lib64 --libexecdir=/lib/udev --enable-logging --enable-static --without-selinux --disable-debug --enable-rule_generator --disable-hwdb --with-pci-ids-path=/usr/share/misc/pci.ids --with-usb-ids-path=/usr/share/misc/usb.ids --disable-udev_acl --disable-gudev --disable-introspection --disable-keymap --disable-floppy --disable-edd --disable-action_modeswitch --with-systemdsystemunitdir=/usr/lib/systemd/system
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking for style of include used by make... GNU
checking for x86_64-pc-linux-gnu-gcc... x86_64-pc-linux-gnu-gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether x86_64-pc-linux-gnu-gcc accepts -g... yes
checking for x86_64-pc-linux-gnu-gcc option to accept ISO C89... none needed
checking dependency style of x86_64-pc-linux-gnu-gcc... none
checking how to run the C preprocessor... x86_64-pc-linux-gnu-gcc -E
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking minix/config.h usability... no
checking minix/config.h presence... no
checking for minix/config.h... no
checking whether it is safe to define __EXTENSIONS__... yes
checking for special C compiler options needed for large files... no
checking for _FILE_OFFSET_BITS value needed for large files... no
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for fgrep... /bin/grep -F
checking for ld used by x86_64-pc-linux-gnu-gcc... /usr/x86_64-pc-linux-gnu/bin/ld
checking if the linker (/usr/x86_64-pc-linux-gnu/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-pc-linux-gnu file names to x86_64-pc-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-pc-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/x86_64-pc-linux-gnu/bin/ld option to reload object files... -r
checking for x86_64-pc-linux-gnu-objdump... x86_64-pc-linux-gnu-objdump
checking how to recognize dependent libraries... pass_all
checking for x86_64-pc-linux-gnu-dlltool... no
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for x86_64-pc-linux-gnu-ar... x86_64-pc-linux-gnu-ar
checking for archiver @FILE support... @
checking for x86_64-pc-linux-gnu-strip... x86_64-pc-linux-gnu-strip
checking for x86_64-pc-linux-gnu-ranlib... x86_64-pc-linux-gnu-ranlib
checking command to parse /usr/bin/nm -B output from x86_64-pc-linux-gnu-gcc object... ok
checking for sysroot... no
checking for x86_64-pc-linux-gnu-mt... no
checking for mt... no
checking if : is a manifest tool... no
checking for dlfcn.h... yes
checking for objdir... .libs
checking if x86_64-pc-linux-gnu-gcc supports -fno-rtti -fno-exceptions... no
checking for x86_64-pc-linux-gnu-gcc option to produce PIC... -fPIC -DPIC
checking if x86_64-pc-linux-gnu-gcc PIC flag -fPIC -DPIC works... yes
checking if x86_64-pc-linux-gnu-gcc static flag -static works... yes
checking if x86_64-pc-linux-gnu-gcc supports -c -o file.o... yes
checking if x86_64-pc-linux-gnu-gcc supports -c -o file.o... (cached) yes
checking whether the x86_64-pc-linux-gnu-gcc linker (/usr/x86_64-pc-linux-gnu/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking for gawk... (cached) gawk
checking for x86_64-pc-linux-gnu-pkg-config... no
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for gtkdoc-check... no
checking for gtkdoc-rebase... /usr/bin/gtkdoc-rebase
checking for gtkdoc-mkpdf... no
checking whether to build gtk-doc documentation... no
checking for xsltproc... /usr/bin/xsltproc
checking for library containing clock_gettime... -lrt
configure: creating ./config.status
config.status: creating Makefile
config.status: creating udev/udev.pc
config.status: creating init/udev.service
config.status: creating init/udev-trigger.service
config.status: creating init/udev-settle.service
config.status: creating libudev/libudev.pc
config.status: creating libudev/docs/Makefile
config.status: creating libudev/docs/version.xml
config.status: creating extras/gudev/gudev-1.0.pc
config.status: creating extras/gudev/docs/Makefile
config.status: creating extras/gudev/docs/version.xml
config.status: creating config.h
config.status: executing depfiles commands
config.status: executing libtool commands
udev 171
====
prefix: /usr
sysconfdir: /etc
sbindir: /sbin
libdir: /usr/lib64
rootlibdir: /lib64
libexecdir: /lib/udev
datarootdir: ${prefix}/share
mandir: /usr/share/man
includedir: ${prefix}/include
include_prefix:
systemdsystemunitdir: /usr/lib/systemd/system
logging: yes
debug: no
selinux: no
compiler: x86_64-pc-linux-gnu-gcc
cflags: -march=native -O2 -pipe
ldflags: -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu
rule_generator: yes
hwdb: no
udev_acl: no
gudev: no
gintrospection: no
keymap: no
floppy: no
edd: no
action_modeswitch: no
usb.ids:
pci.ids:
firmware path: \"/lib/firmware/updates/\", \"/lib/firmware/\"
xsltproc: /usr/bin/xsltproc
gperf:
>>> Source configured.
>>> Compiling source in /var/tmp/portage/sys-fs/udev-171-r6/work/udev-171 ...
make -j7
make --no-print-directory all-recursive
Making all in .
CC libudev/libudev.lo
/bin/sh ./libtool --silent --tagÌ --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o libudev/libudev.lo libudev/libudev.c
CC libudev/libudev-list.lo
/bin/sh ./libtool --silent --tagÌ --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o libudev/libudev-list.lo libudev/libudev-list.c
CC libudev/libudev-util.lo
/bin/sh ./libtool --silent --tagÌ --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o libudev/libudev-util.lo libudev/libudev-util.c
CC libudev/libudev-enumerate.lo
CC libudev/libudev-device.lo
/bin/sh ./libtool --silent --tagÌ --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o libudev/libudev-enumerate.lo libudev/libudev-enumerate.c
CC libudev/libudev-monitor.lo
/bin/sh ./libtool --silent --tagÌ --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o libudev/libudev-device.lo libudev/libudev-device.c
CC libudev/libudev-queue.lo
/bin/sh ./libtool --silent --tagÌ --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o libudev/libudev-monitor.lo libudev/libudev-monitor.c
/bin/sh ./libtool --silent --tagÌ --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o libudev/libudev-queue.lo libudev/libudev-queue.c
CC libudev/libudev-ctrl.lo
/bin/sh ./libtool --silent --tagÌ --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o libudev/libudev-ctrl.lo libudev/libudev-ctrl.c
CC libudev/libudev-util-private.lo
/bin/sh ./libtool --silent --tagÌ --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o libudev/libudev-util-private.lo libudev/libudev-util-private.c
CC libudev/libudev-device-private.lo
/bin/sh ./libtool --silent --tagÌ --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o libudev/libudev-device-private.lo libudev/libudev-device-private.c
libudev/libudev-util-private.c: In function 'util_unlink_secure':
libudev/libudev-util-private.c:123:7: warning: ignoring return value of 'chown', declared with attribute warn_unused_result
CC libudev/libudev-queue-private.lo
/bin/sh ./libtool --silent --tagÌ --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o libudev/libudev-queue-private.lo libudev/libudev-queue-private.c
CC extras/firmware/extras_firmware_firmware-firmware.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -DFIRMWARE_PATH="\"/lib/firmware/updates/\", \"/lib/firmware/\"" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o extras/firmware/extras_firmware_firmware-firmware.o `test -f 'extras/firmware/firmware.c' || echo './'`extras/firmware/firmware.c
CC extras/ata_id/ata_id.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o extras/ata_id/ata_id.o extras/ata_id/ata_id.c
libudev/libudev-queue-private.c: In function 'update_failed':
libudev/libudev-queue-private.c:415:10: warning: ignoring return value of 'symlink', declared with attribute warn_unused_result
libudev/libudev-queue-private.c: In function 'rebuild_queue_file':
libudev/libudev-queue-private.c:231:8: warning: ignoring return value of 'fwrite', declared with attribute warn_unused_result
libudev/libudev-queue-private.c:246:11: warning: ignoring return value of 'fwrite', declared with attribute warn_unused_result
libudev/libudev-queue-private.c:247:11: warning: ignoring return value of 'fwrite', declared with attribute warn_unused_result
libudev/libudev-queue-private.c:248:11: warning: ignoring return value of 'fwrite', declared with attribute warn_unused_result
CC extras/cdrom_id/cdrom_id.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o extras/cdrom_id/cdrom_id.o extras/cdrom_id/cdrom_id.c
CC extras/collect/collect.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o extras/collect/collect.o extras/collect/collect.c
CC extras/input_id/input_id.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o extras/input_id/input_id.o extras/input_id/input_id.c
extras/collect/collect.c: In function ‘main’:
extras/collect/collect.c:460:11: warning: ignoring return value of ‘ftruncate’, declared with attribute warn_unused_result
extras/collect/collect.c:463:7: warning: ignoring return value of ‘lockf’, declared with attribute warn_unused_result
extras/collect/collect.c: In function ‘prepare’:
extras/collect/collect.c:110:9: warning: ignoring return value of ‘lockf’, declared with attribute warn_unused_result
extras/collect/collect.c: In function ‘missing’:
extras/collect/collect.c:302:9: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result
CC extras/path_id/path_id.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o extras/path_id/path_id.o extras/path_id/path_id.c
CC extras/scsi_id/scsi_id.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o extras/scsi_id/scsi_id.o extras/scsi_id/scsi_id.c
CC extras/scsi_id/scsi_serial.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o extras/scsi_id/scsi_serial.o extras/scsi_id/scsi_serial.c
CC extras/usb_id/usb_id.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o extras/usb_id/usb_id.o extras/usb_id/usb_id.c
CC extras/v4l_id/v4l_id.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o extras/v4l_id/v4l_id.o extras/v4l_id/v4l_id.c
extras/path_id/path_id.c: In function ‘handle_scsi_tape’:
extras/path_id/path_id.c:346:11: warning: ignoring return value of ‘asprintf’, declared with attribute warn_unused_result
extras/path_id/path_id.c:348:11: warning: ignoring return value of ‘asprintf’, declared with attribute warn_unused_result
CC extras/mtd_probe/extras_mtd_probe_mtd_probe-mtd_probe.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o extras/mtd_probe/extras_mtd_probe_mtd_probe-mtd_probe.o `test -f 'extras/mtd_probe/mtd_probe.c' || echo './'`extras/mtd_probe/mtd_probe.c
CC extras/mtd_probe/extras_mtd_probe_mtd_probe-probe_smartmedia.o
CC udev/udev-event.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o extras/mtd_probe/extras_mtd_probe_mtd_probe-probe_smartmedia.o `test -f 'extras/mtd_probe/probe_smartmedia.c' || echo './'`extras/mtd_probe/probe_smartmedia.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o udev/udev-event.o udev/udev-event.c
CC udev/udev-watch.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o udev/udev-watch.o udev/udev-watch.c
CC udev/udev-node.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o udev/udev-node.o udev/udev-node.c
CC udev/udev-rules.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o udev/udev-rules.o udev/udev-rules.c
CC udev/udevd.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o udev/udevd.o udev/udevd.c
CC udev/sd-daemon.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o udev/sd-daemon.o udev/sd-daemon.c
udev/udev-watch.c: In function ‘udev_watch_begin’:
udev/udev-watch.c:124:9: warning: ignoring return value of ‘symlink’, declared with attribute warn_unused_result
udev/udev-event.c: In function ‘udev_event_apply_format’:
udev/udev-event.c:384:12: warning: ignoring return value of ‘asprintf’, declared with attribute warn_unused_result
udev/udev-node.c: In function ‘udev_node_mknod’:
udev/udev-node.c:58:10: warning: ignoring return value of ‘chown’, declared with attribute warn_unused_result
udev/udev-node.c:94:9: warning: ignoring return value of ‘chown’, declared with attribute warn_unused_result
udev/udev-node.c:112:8: warning: ignoring return value of ‘chown’, declared with attribute warn_unused_result
udev/udevd.c: In function ‘main’:
udev/udevd.c:1329:7: warning: ignoring return value of ‘chdir’, declared with attribute warn_unused_result
udev/udevd.c:1440:10: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result
udev/udevd.c:1444:9: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result
udev/udevd.c: In function ‘copy_dev_dir’:
udev/udevd.c:927:13: warning: ignoring return value of ‘fchmodat’, declared with attribute warn_unused_result
udev/udevd.c:928:13: warning: ignoring return value of ‘fchownat’, declared with attribute warn_unused_result
udev/udev-rules.c: In function ‘udev_rules_apply_static_dev_perms’:
udev/udev-rules.c:2726:10: warning: ignoring return value of ‘chown’, declared with attribute warn_unused_result
CC udev/udevadm.o
CC udev/udevadm-info.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o udev/udevadm.o udev/udevadm.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o udev/udevadm-info.o udev/udevadm-info.c
CC udev/udevadm-control.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o udev/udevadm-control.o udev/udevadm-control.c
CC udev/udevadm-test.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o udev/udevadm-test.o udev/udevadm-test.c
CC udev/udevadm-monitor.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o udev/udevadm-monitor.o udev/udevadm-monitor.c
CC udev/udevadm-settle.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o udev/udevadm-settle.o udev/udevadm-settle.c
CC udev/udevadm-trigger.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o udev/udevadm-trigger.o udev/udevadm-trigger.c
udev/udevadm-settle.c: In function ‘udevadm_settle’:
udev/udevadm-settle.c:196:9: warning: ignoring return value of ‘read’, declared with attribute warn_unused_result
CCLD libudev/libudev.la
CCLD libudev/libudev-private.la
CCLD extras/mtd_probe/mtd_probe
CCLD extras/firmware/firmware
CCLD extras/ata_id/ata_id
CCLD extras/cdrom_id/cdrom_id
CCLD extras/collect/collect
CCLD extras/input_id/input_id
CCLD extras/path_id/path_id
CCLD extras/scsi_id/scsi_id
CCLD extras/usb_id/usb_id
CCLD extras/v4l_id/v4l_id
CCLD udev/udevd
CCLD udev/udevadm
Making all in libudev/docs
make[2]: Nothing to be done for `all'.
>>> Source compiled.
>>> Test phase [udev:check]: sys-fs/udev-171-r6
* Disable FEATURES userpriv to run the udev tests
make --no-print-directory check-recursive
Making check in .
make --no-print-directory libudev/test-libudev udev/test-udev
CC libudev/test-libudev.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o libudev/test-libudev.o libudev/test-libudev.c
CCLD libudev/test-libudev
CC udev/test-udev.o
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ./config.h -I./libudev -DSYSCONFDIR=\""/etc"\" -DLIBEXECDIR=\""/lib/udev"\" -fvisibility=hidden -ffunction-sections -fdata-sections -march=native -O2 -pipe -c -o udev/test-udev.o udev/test-udev.c
CCLD udev/test-udev
make --no-print-directory check-TESTS
Must have root permissions to run properly.
PASS: test/udev-test.pl
File "./test/rule-syntax-check.py", line 58
print 'Invalid line %s:%i: %s' % (path, lineno, line)
^
SyntaxError: invalid syntax
FAIL: test/rules-test.sh
=======================
1 of 2 tests failed
Please report to linux-hotplug@vger.kernel.org
=======================
make[3]: *** [check-TESTS] Error 1
make[2]: *** [check-am] Error 2
make[1]: *** [check-recursive] Error 1
make: *** [check] Error 2
* ERROR: sys-fs/udev-171-r6 failed (test phase):
* udev: Make test failed. See above for details.
*
* Call stack:
* ebuild.sh, line 85: Called src_test
* environment, line 3687: Called die
* The specific snippet of code:
* has test $FEATURES && die "udev: Make test failed. See above for details.";
*
* If you need support, post the output of `emerge --info '=sys-fs/udev-171-r6'`,
* the complete build log and the output of `emerge -pqv '=sys-fs/udev-171-r6'`.
* The complete build log is located at '/home/mingdao/portage_logs/build/sys-fs/udev-171-r6:20120722-051032.log'.
* For convenience, a symlink to the build log is located at '/var/tmp/portage/sys-fs/udev-171-r6/temp/build.log'.
* The ebuild environment file is located at '/var/tmp/portage/sys-fs/udev-171-r6/temp/environment'.
* Working directory: '/var/tmp/portage/sys-fs/udev-171-r6/work/udev-171'
* S: '/var/tmp/portage/sys-fs/udev-171-r6/work/udev-171'
Please CC: me, I'm not on the list.
Bruce Hill
--
Happy Penguin Computers >')
126 Fenco Drive ( \
Tupelo, MS 38801 ^^
support@happypenguincomputers.com
662-269-2706 662-205-6424
http://happypenguincomputers.com/
Don't top-post: http://en.wikipedia.org/wiki/Top_post#Top-posting
^ permalink raw reply
* Cabled PCIE device hotplug/hot-removal
From: Shlomo Pongratz @ 2012-07-26 17:03 UTC (permalink / raw)
To: linux-pci, linux-hotplug
Hi,
I have a PCIe device connected with cables to a host (kernel 3.5.0-rc7+).
What are the handler I need to add to a driver in order to catch cable
pull-out / push-in?
The pcisig presentation
"http://www.pcisig.com/developers/main/training_materials/get_document?doc_idôca40ec1721aa7fadd05e2903b0172c36656294"
talks about PERST# detection for cabled PCIe hotplug.
Does the kernel detect it?
None of the pci_driver or pci_error_handlers callbacks were called
when using powered down/up the device (electrically).
Thanks.
Shlomo Pongratz
^ permalink raw reply
* Re: Cabled PCIE device hotplug/hot-removal
From: Greg KH @ 2012-07-26 17:09 UTC (permalink / raw)
To: Shlomo Pongratz; +Cc: linux-pci, linux-hotplug
In-Reply-To: <CAHzK-V0XpkVJHgqWiWpYP1jx5DPX=voE0eymK+5FG-zhrJOwAQ@mail.gmail.com>
On Thu, Jul 26, 2012 at 08:03:09PM +0300, Shlomo Pongratz wrote:
> Hi,
>
> I have a PCIe device connected with cables to a host (kernel 3.5.0-rc7+).
> What are the handler I need to add to a driver in order to catch cable
> pull-out / push-in?
You shouldn't need anything special, aren't you already getting probe
and disconnect callbacks when the device is discovered and removed?
> The pcisig presentation
> "http://www.pcisig.com/developers/main/training_materials/get_document?doc_idôca40ec1721aa7fadd05e2903b0172c36656294"
> talks about PERST# detection for cabled PCIe hotplug.
>
> Does the kernel detect it?
>
> None of the pci_driver or pci_error_handlers callbacks were called
> when using powered down/up the device (electrically).
Do you have the pciehp driver loaded properly when this happens?
thanks,
greg k-h
^ permalink raw reply
* Re: [systemd-devel] [PATCH] Always populate EXTRA_DIST
From: Bryan Kadzban @ 2012-07-28 2:43 UTC (permalink / raw)
To: linux-hotplug
In-Reply-To: <4FD195C7.6010808@kadzban.is-a-geek.net>
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
Lennart Poettering wrote:
> On Thu, 07.06.12 23:24, Bryan Kadzban (bryan@kadzban.is-a-geek.net) wrote:
>
>> Bryan Kadzban wrote:
>>> "make dist" can build a different tarball depending on the flags passed
>>> to ./configure and the (optional) dependencies found on the system.
>>> Move all append-to-EXTRA_DIST operations out of automake conditionals to
>>> fix this.
>>>
>>> Introduce a polkitpolicy_files so that the policy files built still
>>> correctly depend on the automake conditionals, but the .in files that
>>> get distributed do not.
>>>
>>> Signed-Off-By: Bryan Kadzban <bryan.kadzban.is-a-geek.net>
>> Arg, always compile-check. Tested, this time.
>>
>> v2, fixing warnings about polkitpolicy_files not being defined.
>
> Looks good, but could you rebase this to current master? Will apply then.
v3, rebased. (Finally got time to do this.)
[-- Attachment #2: systemd-always-populate-extra_dist.patch --]
[-- Type: text/plain, Size: 8851 bytes --]
diff --git a/Makefile.am b/Makefile.am
index a74a806..e4dfafb 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -95,6 +95,7 @@ lib_LTLIBRARIES =
include_HEADERS =
pkgconfiglib_DATA =
polkitpolicy_in_files =
+polkitpolicy_files =
dist_udevrules_DATA =
nodist_udevrules_DATA =
dist_man_MANS =
@@ -1950,9 +1951,6 @@ lib_LTLIBRARIES += libgudev-1.0.la
pkgconfiglib_DATA += \
src/gudev/gudev-1.0.pc
-EXTRA_DIST += \
- src/gudev/gudev-1.0.pc.in
-
CLEANFILES += \
src/gudev/gudev-1.0.pc
@@ -2003,14 +2001,6 @@ libgudev_1_0_la_LDFLAGS = \
-export-dynamic -no-undefined \
-export-symbols-regex '^g_udev_.*'
-EXTRA_DIST += \
- src/gudev/gudevmarshal.list \
- src/gudev/gudevenumtypes.h.template \
- src/gudev/gudevenumtypes.c.template \
- src/gudev/gjs-example.js \
- src/gudev/seed-example-enum.js \
- src/gudev/seed-example.js
-
src/gudev/gudevmarshal.h: src/gudev/gudevmarshal.list
$(AM_V_GEN)glib-genmarshal $< --prefix=g_udev_marshal --header > $@
@@ -2091,6 +2081,16 @@ INSTALL_EXEC_HOOKS += libgudev-install-move-hook
UNINSTALL_EXEC_HOOKS += libgudev-uninstall-move-hook
endif
+EXTRA_DIST += \
+ src/gudev/gudev-1.0.pc.in \
+ src/gudev/gudevmarshal.list \
+ src/gudev/gudevenumtypes.h.template \
+ src/gudev/gudevenumtypes.c.template \
+ src/gudev/gjs-example.js \
+ src/gudev/seed-example-enum.js \
+ src/gudev/seed-example.js
+
+
# ------------------------------------------------------------------------------
if ENABLE_KEYMAP
keymap_SOURCES = \
@@ -2126,10 +2126,6 @@ dist_udevhome_SCRIPTS = \
TESTS += \
src/udev/keymap/check-keymaps.sh
-EXTRA_DIST += \
- src/udev/keymap/check-keymaps.sh \
- src/udev/keymap/keyboard-force-release.sh.in
-
CLEANFILES += \
src/udev/keymap/keys.txt \
src/udev/keymap/keys-from-name.gperf \
@@ -2219,6 +2215,10 @@ src/udev/keymap/keys-to-name.h: src/udev/keymap/keys.txt Makefile
$(AM_V_GEN)$(AWK) 'BEGIN{ print "const char* const key_names[KEY_CNT] = { "} { print "[" $$1 "] = \"" $$1 "\"," } END{print "};"}' < $< > $@
endif
+EXTRA_DIST += \
+ src/udev/keymap/check-keymaps.sh \
+ src/udev/keymap/keyboard-force-release.sh.in
+
# ------------------------------------------------------------------------------
mtd_probe_SOURCES = \
src/udev/mtd_probe/mtd_probe.c \
@@ -2550,13 +2550,13 @@ rootlibexec_PROGRAMS += \
sysctl_DATA = \
sysctl.d/coredump.conf
-EXTRA_DIST += \
- sysctl.d/coredump.conf.in
-
CLEANFILES += \
sysctl.d/coredump.conf
endif
+EXTRA_DIST += \
+ sysctl.d/coredump.conf.in
+
# ------------------------------------------------------------------------------
if ENABLE_BINFMT
systemd_binfmt_SOURCES = \
@@ -2597,10 +2597,10 @@ MANPAGES_ALIAS += \
man/systemd-binfmt.8
man/systemd-binfmt.8: man/systemd-binfmt.service.8
+endif
EXTRA_DIST += \
units/systemd-binfmt.service.in
-endif
# ------------------------------------------------------------------------------
if ENABLE_VCONSOLE
@@ -2634,10 +2634,10 @@ MANPAGES_ALIAS += \
man/systemd-vconsole-setup.8
man/systemd-vconsole-setup.8: man/systemd-vconsole-setup.service.8
+endif
EXTRA_DIST += \
units/systemd-vconsole-setup.service.in
-endif
# ------------------------------------------------------------------------------
if ENABLE_READAHEAD
@@ -2670,11 +2670,6 @@ nodist_systemunit_DATA += \
units/systemd-readahead-replay.service \
units/systemd-readahead-done.service
-EXTRA_DIST += \
- units/systemd-readahead-collect.service.in \
- units/systemd-readahead-replay.service.in \
- units/systemd-readahead-done.service.in
-
MANPAGES += \
man/sd_readahead.3 \
man/sd-readahead.3 \
@@ -2693,6 +2688,11 @@ man/systemd-readahead.8: man/systemd-readahead-replay.service.8
endif
+EXTRA_DIST += \
+ units/systemd-readahead-collect.service.in \
+ units/systemd-readahead-replay.service.in \
+ units/systemd-readahead-done.service.in
+
# ------------------------------------------------------------------------------
if ENABLE_QUOTACHECK
rootlibexec_PROGRAMS += \
@@ -2701,9 +2701,6 @@ rootlibexec_PROGRAMS += \
nodist_systemunit_DATA += \
units/systemd-quotacheck.service
-EXTRA_DIST += \
- units/systemd-quotacheck.service.in
-
systemd_quotacheck_SOURCES = \
src/quotacheck/quotacheck.c
@@ -2720,6 +2717,9 @@ man/systemd-quotacheck.8: man/systemd-quotacheck.service.8
endif
+EXTRA_DIST += \
+ units/systemd-quotacheck.service.in
+
# ------------------------------------------------------------------------------
if ENABLE_RANDOMSEED
rootlibexec_PROGRAMS += \
@@ -2729,10 +2729,6 @@ nodist_systemunit_DATA += \
units/systemd-random-seed-save.service \
units/systemd-random-seed-load.service
-EXTRA_DIST += \
- units/systemd-random-seed-save.service.in \
- units/systemd-random-seed-load.service.in
-
systemd_random_seed_SOURCES = \
src/random-seed/random-seed.c
@@ -2766,6 +2762,10 @@ man/systemd-random-seed.8: man/systemd-random-seed-load.service.8
endif
+EXTRA_DIST += \
+ units/systemd-random-seed-save.service.in \
+ units/systemd-random-seed-load.service.in
+
# ------------------------------------------------------------------------------
if HAVE_LIBCRYPTSETUP
rootlibexec_PROGRAMS += \
@@ -2845,8 +2845,8 @@ dist_dbuspolicy_DATA += \
dist_dbussystemservice_DATA += \
src/hostname/org.freedesktop.hostname1.service
-polkitpolicy_in_files += \
- src/hostname/org.freedesktop.hostname1.policy.in
+polkitpolicy_files += \
+ src/hostname/org.freedesktop.hostname1.policy
dbusinterface_DATA += \
org.freedesktop.hostname1.xml
@@ -2871,10 +2871,13 @@ MANPAGES_ALIAS += \
man/systemd-hostnamed.8
man/systemd-hostnamed.8: man/systemd-hostnamed.service.8
+endif
+
+polkitpolicy_in_files += \
+ src/hostname/org.freedesktop.hostname1.policy.in
EXTRA_DIST += \
units/systemd-hostnamed.service.in
-endif
# ------------------------------------------------------------------------------
if ENABLE_LOCALED
@@ -2903,8 +2906,8 @@ dist_dbuspolicy_DATA += \
dist_dbussystemservice_DATA += \
src/locale/org.freedesktop.locale1.service
-polkitpolicy_in_files += \
- src/locale/org.freedesktop.locale1.policy.in
+polkitpolicy_files += \
+ src/locale/org.freedesktop.locale1.policy
dbusinterface_DATA += \
org.freedesktop.locale1.xml
@@ -2930,9 +2933,6 @@ MANPAGES_ALIAS += \
man/systemd-localed.8: man/systemd-localed.service.8
-EXTRA_DIST += \
- units/systemd-localed.service.in
-
dist_pkgdata_DATA += \
src/locale/kbd-model-map
@@ -2944,6 +2944,12 @@ update-kbd-model-map:
endif
+polkitpolicy_in_files += \
+ src/locale/org.freedesktop.locale1.policy.in
+
+EXTRA_DIST += \
+ units/systemd-localed.service.in
+
# ------------------------------------------------------------------------------
if ENABLE_TIMEDATED
systemd_timedated_SOURCES = \
@@ -2970,8 +2976,8 @@ dist_dbuspolicy_DATA += \
nodist_systemunit_DATA += \
units/systemd-timedated.service
-polkitpolicy_in_files += \
- src/timedate/org.freedesktop.timedate1.policy.in
+polkitpolicy_files += \
+ src/timedate/org.freedesktop.timedate1.policy
org.freedesktop.timedate1.xml: systemd-timedated
$(AM_V_GEN)$(LIBTOOL) --mode=execute $(OBJCOPY) -O binary -j introspect.timedate1 $< $@.tmp && \
@@ -2999,10 +3005,13 @@ MANPAGES_ALIAS += \
man/systemd-timedated.8
man/systemd-timedated.8: man/systemd-timedated.service.8
+endif
+
+polkitpolicy_in_files += \
+ src/timedate/org.freedesktop.timedate1.policy.in
EXTRA_DIST += \
units/systemd-timedated.service.in
-endif
# ------------------------------------------------------------------------------
if ENABLE_LOGIND
@@ -3204,8 +3213,8 @@ noinst_LTLIBRARIES += \
pkgconfiglib_DATA += \
src/login/libsystemd-login.pc
-polkitpolicy_in_files += \
- src/login/org.freedesktop.login1.policy.in
+polkitpolicy_files += \
+ src/login/org.freedesktop.login1.policy
logind-install-data-hook:
$(MKDIR_P) -m 0755 \
@@ -3301,6 +3310,15 @@ man/sd_get_sessions.3: man/sd_get_seats.3
man/sd_get_uids.3: man/sd_get_seats.3
man/systemd-user-sessions.8: man/systemd-user-sessions.service.8
+CLEANFILES += \
+ src/login/logind-gperf.c \
+ src/login/71-seat.rules \
+ src/login/73-seat-late.rules
+endif
+
+polkitpolicy_in_files += \
+ src/login/org.freedesktop.login1.policy.in
+
EXTRA_DIST += \
src/login/logind-gperf.gperf \
src/login/libsystemd-login.pc.in \
@@ -3310,11 +3328,6 @@ EXTRA_DIST += \
units/systemd-logind.service.in \
units/systemd-user-sessions.service.in
-CLEANFILES += \
- src/login/logind-gperf.c \
- src/login/71-seat.rules \
- src/login/73-seat-late.rules
-endif
# ------------------------------------------------------------------------------
SED_PROCESS = \
@@ -3390,7 +3403,7 @@ units/user/%: units/%.m4 Makefile
$(M4_PROCESS_USER)
nodist_polkitpolicy_DATA = \
- $(polkitpolicy_in_files:.policy.in=.policy) \
+ $(polkitpolicy_files) \
$(polkitpolicy_in_in_files:.policy.in.in=.policy)
EXTRA_DIST += \
^ permalink raw reply related
* Re: [systemd-devel] [PATCH] Always populate EXTRA_DIST
From: Zbigniew Jędrzejewski-Szmek @ 2012-07-28 21:14 UTC (permalink / raw)
To: linux-hotplug
In-Reply-To: <4FD195C7.6010808@kadzban.is-a-geek.net>
On 07/28/2012 04:43 AM, Bryan Kadzban wrote:
> Lennart Poettering wrote:
>> On Thu, 07.06.12 23:24, Bryan Kadzban (bryan@kadzban.is-a-geek.net) wrote:
>>
>>> Bryan Kadzban wrote:
>>>> "make dist" can build a different tarball depending on the flags passed
>>>> to ./configure and the (optional) dependencies found on the system.
>>>> Move all append-to-EXTRA_DIST operations out of automake conditionals to
>>>> fix this.
>>>>
>>>> Introduce a polkitpolicy_files so that the policy files built still
>>>> correctly depend on the automake conditionals, but the .in files that
>>>> get distributed do not.
>>>>
>>>> Signed-Off-By: Bryan Kadzban <bryan.kadzban.is-a-geek.net>
>>> Arg, always compile-check. Tested, this time.
>>>
>>> v2, fixing warnings about polkitpolicy_files not being defined.
>>
>> Looks good, but could you rebase this to current master? Will apply then.
>
> v3, rebased. (Finally got time to do this.)
Commited.
Zbyszek
^ permalink raw reply
* Re: Cabled PCIE device hotplug/hot-removal
From: Shlomo Pongratz @ 2012-07-29 12:36 UTC (permalink / raw)
To: Greg KH; +Cc: linux-pci, linux-hotplug
In-Reply-To: <20120726170925.GA24751@kroah.com>
On Thu, Jul 26, 2012 at 8:09 PM, Greg KH <greg@kroah.com> wrote:
> On Thu, Jul 26, 2012 at 08:03:09PM +0300, Shlomo Pongratz wrote:
>> Hi,
>>
>> I have a PCIe device connected with cables to a host (kernel 3.5.0-rc7+).
>> What are the handler I need to add to a driver in order to catch cable
>> pull-out / push-in?
>
> You shouldn't need anything special, aren't you already getting probe
> and disconnect callbacks when the device is discovered and removed?
When the device is loaded the probe is called
When I "echo 1" to the remove sysfs entry the remove callback is called.
But when I power down the card no callback is called.
>
>> The pcisig presentation
>> "http://www.pcisig.com/developers/main/training_materials/get_document?doc_idôca40ec1721aa7fadd05e2903b0172c36656294"
>> talks about PERST# detection for cabled PCIe hotplug.
>>
>> Does the kernel detect it?
>>
>> None of the pci_driver or pci_error_handlers callbacks were called
>> when using powered down/up the device (electrically).
>
> Do you have the pciehp driver loaded properly when this happens?
My {dot}config includes it into the kernel, i.e.
CONFIG_HOTPLUG_PCI_PCIE=y
>
> thanks,
>
> greg k-h
Thanks,
^ permalink raw reply
* Re: Cabled PCIE device hotplug/hot-removal
From: Greg KH @ 2012-07-29 14:59 UTC (permalink / raw)
To: Shlomo Pongratz; +Cc: linux-pci, linux-hotplug
In-Reply-To: <CAHzK-V0idPrHhf-YuC_HAxxxQABExW7mUUWN31f-ZpdnC8W+GA@mail.gmail.com>
On Sun, Jul 29, 2012 at 03:36:09PM +0300, Shlomo Pongratz wrote:
> On Thu, Jul 26, 2012 at 8:09 PM, Greg KH <greg@kroah.com> wrote:
> > On Thu, Jul 26, 2012 at 08:03:09PM +0300, Shlomo Pongratz wrote:
> >> Hi,
> >>
> >> I have a PCIe device connected with cables to a host (kernel 3.5.0-rc7+).
> >> What are the handler I need to add to a driver in order to catch cable
> >> pull-out / push-in?
> >
> > You shouldn't need anything special, aren't you already getting probe
> > and disconnect callbacks when the device is discovered and removed?
>
> When the device is loaded the probe is called
> When I "echo 1" to the remove sysfs entry the remove callback is called.
> But when I power down the card no callback is called.
Then I would blame your pci hotplug controller, that is its
responsibility.
> >> The pcisig presentation
> >> "http://www.pcisig.com/developers/main/training_materials/get_document?doc_idôca40ec1721aa7fadd05e2903b0172c36656294"
> >> talks about PERST# detection for cabled PCIe hotplug.
> >>
> >> Does the kernel detect it?
> >>
> >> None of the pci_driver or pci_error_handlers callbacks were called
> >> when using powered down/up the device (electrically).
> >
> > Do you have the pciehp driver loaded properly when this happens?
>
> My {dot}config includes it into the kernel, i.e.
> CONFIG_HOTPLUG_PCI_PCIE=y
And is it working properly? Does your hardware support this (i.e. your
BIOS?)
greg k-h
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox