Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: <markus.stockhausen@gmx.de>
To: "'Guenter Roeck'" <linux@roeck-us.net>
Cc: <linux-hwmon@vger.kernel.org>, <sashiko@lists.linux.dev>
Subject: AW: [PATCH 1/2] hwmon: (lm75) Fix AS6200 setup and alarm handling
Date: Mon, 4 May 2026 17:03:45 +0200	[thread overview]
Message-ID: <003b01dcdbd7$34d247c0$9e76d740$@gmx.de> (raw)
In-Reply-To: <8928c046-69fa-4578-9a7d-87b98fc7c5a2@roeck-us.net>

> Von: Guenter Roeck <groeck7@gmail.com> Im Auftrag von Guenter Roeck
> Gesendet: Samstag, 2. Mai 2026 16:45
> An: sashiko@lists.linux.dev; Markus Stockhausen <markus.stockhausen@gmx.de>
> Cc: linux-hwmon@vger.kernel.org
> Betreff: Re: [PATCH 1/2] hwmon: (lm75) Fix AS6200 setup and alarm handling
> 
> ...
> Either case, I ended up ordering an evaluation board for as6200 and samples
> for TMP112, so we'll see how this works for real once I get that.

Looking at this again that is a good idea. device_params says 8 bit sampling (aka 
2 consecutive bits = 1) is in bits 6/7

	[as6200] = {
		.config_reg_16bits = true,
		.set_mask = 0x10C0,	/* 8 sample/s, 4 CF */

	[tmp112] = {
		.config_reg_16bits = true,
		.set_mask = 0x60C0,	/* 12-bit mode, 8 samples / second */

But lm75_update_interval() uses bits 14/15.

	case tmp112:
	case as6200:
		err = regmap_update_bits(data->regmap, LM75_REG_CONF,
					 0xc000, (3 - index) << 14);

This confuses me and maybe the bot ...

Markus


  reply	other threads:[~2026-05-04 15:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-02  9:45 [PATCH 0/2] hwmon: (lm75) Fix AS6200 setup and alarm handling Markus Stockhausen
2026-05-02  9:45 ` [PATCH 1/2] " Markus Stockhausen
2026-05-02 10:10   ` sashiko-bot
2026-05-02 14:45     ` Guenter Roeck
2026-05-04 15:03       ` markus.stockhausen [this message]
2026-05-02 14:48   ` Guenter Roeck
2026-05-02  9:45 ` [PATCH 2/2] hwmon: (lm75) Fix configuration register writes Markus Stockhausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='003b01dcdbd7$34d247c0$9e76d740$@gmx.de' \
    --to=markus.stockhausen@gmx.de \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=sashiko@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox