Re: [PATCH 2/3] dt-bindings: hwmon: Add Sensirion SHT3x and GXCAS GXHT30

[Krzysztof Kozlowski <krzk@kernel.org>]

On 19/03/2026 12:19, Zaixiang Xu wrote:
> Add YAML devicetree binding schema for Sensirion SHT3x series and GXCAS GXHT30 humidity and temperature sensors.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

> 
> Signed-off-by: Zaixiang Xu <zaixiang.xu.dev@gmail.com>
> ---
>  .../bindings/hwmon/sensirion,sht3x.yaml       | 44 +++++++++++++++++++
>  1 file changed, 44 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,sht3x.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/sensirion,sht3x.yaml b/Documentation/devicetree/bindings/hwmon/sensirion,sht3x.yaml
> new file mode 100644
> index 000000000000..47dbb743e2ee
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/sensirion,sht3x.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/sensirion,sht3x.yaml#
> +$schema: http://devicetree.org/meta-schema.yaml#
> +
> +title: Sensirion SHT3x Humidity and Temperature Sensor
> +
> +maintainers:
> +  - Zaixiang Xu <zaixiang.xu.dev@gmail.com>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.


> +  The SHT3x series is a family of humidity and temperature sensors by Sensirion.
> +  It also includes compatible sensors like GXCAS GXHT30.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - sensirion,sht3x

What the 'x' stands for? Wildcard?

> +      - sensirion,sts3x
> +      - sensirion,sht85
> +      - gxcas,gxht30

Keep alphabetical order.

> +
> +  reg:
> +    maxItems: 1
> +    description: I2C address (usually 0x44 or 0x45)
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        sensor@44 {
> +            compatible = "gxcas,gxht30";
> +            reg = <0x44>;
> +        };
> +    };
> \ No newline at end of file

You have patch warnings.

No resources? No pins, supplies? Then it looks like trivial device so
should go to trivial-devices.


Best regards,
Krzysztof