From: Guenter Roeck <linux@roeck-us.net>
To: Pawel Dembicki <paweldembicki@gmail.com>
Cc: linux-hwmon@vger.kernel.org,
Antoniu Miclaus <antoniu.miclaus@analog.com>,
Jean Delvare <jdelvare@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: ltc2991: fix register bits defines
Date: Sun, 1 Sep 2024 06:40:17 -0700 [thread overview]
Message-ID: <02cf392d-57cb-48fe-930d-597f415520a4@roeck-us.net> (raw)
In-Reply-To: <20240830111349.30531-1-paweldembicki@gmail.com>
On Fri, Aug 30, 2024 at 01:13:50PM +0200, Pawel Dembicki wrote:
> In the LTC2991, V5 and V6 channels use the low nibble of the
> "V5, V6, V7, and V8 Control Register" for configuration, but currently,
> the high nibble is defined.
>
> This patch changes the defines to use the low nibble.
>
> Fixes: 2b9ea4262ae9 ("hwmon: Add driver for ltc2991")
> Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/ltc2991.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hwmon/ltc2991.c b/drivers/hwmon/ltc2991.c
> index 573cd8f5721b..7ca139e4b6af 100644
> --- a/drivers/hwmon/ltc2991.c
> +++ b/drivers/hwmon/ltc2991.c
> @@ -42,9 +42,9 @@
> #define LTC2991_V7_V8_FILT_EN BIT(7)
> #define LTC2991_V7_V8_TEMP_EN BIT(5)
> #define LTC2991_V7_V8_DIFF_EN BIT(4)
> -#define LTC2991_V5_V6_FILT_EN BIT(7)
> -#define LTC2991_V5_V6_TEMP_EN BIT(5)
> -#define LTC2991_V5_V6_DIFF_EN BIT(4)
> +#define LTC2991_V5_V6_FILT_EN BIT(3)
> +#define LTC2991_V5_V6_TEMP_EN BIT(1)
> +#define LTC2991_V5_V6_DIFF_EN BIT(0)
>
> #define LTC2991_REPEAT_ACQ_EN BIT(4)
> #define LTC2991_T_INT_FILT_EN BIT(3)
prev parent reply other threads:[~2024-09-01 13:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 11:13 [PATCH] hwmon: ltc2991: fix register bits defines Pawel Dembicki
2024-09-01 13:40 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02cf392d-57cb-48fe-930d-597f415520a4@roeck-us.net \
--to=linux@roeck-us.net \
--cc=antoniu.miclaus@analog.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paweldembicki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox