From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f177.google.com (mail-dy1-f177.google.com [74.125.82.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF8A7319847 for ; Thu, 14 May 2026 02:14:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778724865; cv=none; b=S6bHztdtkOElHueAtmUWd0+Cx4E1H7fi6mgPL2onsZulLWZtMUBiyRTp4c/YjqU2RrFjbfVmsDEjSy3KaK5S3/PmoWnEGp1CSGhrdBz+wsGP/jhNsvy0UUp+FGwzyqqLqz7PK4YqVNTCk0R0L1uPDcpiyht4DFQEdMfWTLhxosc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778724865; c=relaxed/simple; bh=gE2HvHmwzigNwBPoHesD9UdxhZ0Ehim6vcqs+z7Mods=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gzPSnABszicj67dyzMpnH+B6MJ5UIZWIi7i7Tvo6YK7alnKj3V8fEIG6sw7C9reTmrXOd7sjJPCNZJe/xz6nP0x7qTBb3jJAthkjrWuMYexeg1y3bz/MpnBlNLRj/dpQExt+v82kArCrfdUojZMABkymMIFZ5WFiWDUqaAGJ7wM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CPE5IdX8; arc=none smtp.client-ip=74.125.82.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CPE5IdX8" Received: by mail-dy1-f177.google.com with SMTP id 5a478bee46e88-2f36da5c8fbso7372036eec.0 for ; Wed, 13 May 2026 19:14:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778724862; x=1779329662; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=7Qpmkf3DSLZHVaV2Sltdw1pOYMH7v1LuMy0tCXwCkfs=; b=CPE5IdX8dRRSZ4gzki0h+ZMiDi6w4REuS5hSGab8NF4Zc3VtcW//6xi/krYf3zZx7l ImnLW2BvQg45e1JsrA2XXHhaOCVctRmSGCAQuHmLF88utnaKBKKuUxl0/5oJTOK//5Tu p0JC4y/FBQO8EyfCULkLLZWjqDfeWQvVbMoteLwzL/B/M2tIjl9dSer1fA3D5qbT/+dC WXeq2Ykb6LUTiUEIKt4GGz5GKwgRiNkUjfocvW1Y8+3iuD5+SrRJB8z2w7tJPv2AWsdU 9LHmRSzJYK4VxNT8YPvKPJccvesLd9ZwHr+/2bVuWF13wOUYlpuWre4gICAWvQQcMCpI ZvMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778724862; x=1779329662; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7Qpmkf3DSLZHVaV2Sltdw1pOYMH7v1LuMy0tCXwCkfs=; b=OS8D2PE/M/2/Ghap4wZlLjE2l30TALYa9n58kv3myA2PP1s+YAYSoih5El21pYmG6w UM3+4AtIlda8XxVy9zBak8VtqMo5BTbYjGkU/pVwpR0bwBIjV/p3Ew2bXuLIE23+aaD4 yJDamNVqR4jZOJJJFPGHQaH12v7UY+2Ci8f7dCE+oeWurTINQBAnHvDZrjv8rlZBEYUJ 8mbmv9XFlRBHqXoOf9VBaV3yKVX/7rIKWLr8Dw4BCT4ki3iP5Qlx7RPekCGltS8C9zcl hcFFio03s6ZOXJ0G68GSUsOxlAVAVXWLjDyLdRv5KByN+bsGf1XwHM6JCP/TJurv+dvg Z0fQ== X-Gm-Message-State: AOJu0YwZu9p2AgjaItat/cU9LeKUheh053SAXlvHgmrTQ7M2VbjTRswW oqY0GZekkUrOz2Lo7n8e+534SD/iqJe9UMnQ+lSecofSHZI+tY+J+pLV X-Gm-Gg: Acq92OFhuwFsnYiWsiy3XVnPSQufqC5VM8BGh89HLSDrCaUne8ZM2DEWP5SuC1VyNwi zKjhP3fn2PplXss+UjWzZ62tmMlTR96zU18ssqNVxvSOhXmigcCZBl54z8rnBlE15aHZgdyJ0pw 6nN+9Uy64WdZwf8zVJFbWR1NRMEXa3RV+NEe2MqiacKjJMB6NLOVMtDH/nZ6+gx8SLulGy+wqqi 5pl8xaNIngv6+qzF2NVxHxANlcKVU+bc2mLCFzCapybjyYBGworLSFahXpb30yfC66EkS/2AaPc xIbpYjjSdOL7hFj4iT0zXIM5yWeSLBJurRHaeNvu60P02nox1zq8SfB2d1mainJe+tqDnUlWAlD 6NoXTqExi7v8Xp2dMvzCjw2Z/gIHK4ZafO0JLUflAjb9TJwpMyQ41KgItvkYGXK7U1wVWtHUti/ w8iG9OJqWJn3cTYUQtOv7ICk5cP05ocZuj67DEK6j+33LqsJz5oGpHFnZn1HY89R8sVezlxN/D X-Received: by 2002:a05:7301:22a8:b0:2d3:2983:c87c with SMTP id 5a478bee46e88-30117c7eb93mr3806778eec.1.1778724861950; Wed, 13 May 2026 19:14:21 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-302978ad18asm1259151eec.26.2026.05.13.19.14.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2026 19:14:21 -0700 (PDT) Sender: Guenter Roeck Message-ID: <045f1907-0180-46df-a123-cd0ce349e86b@roeck-us.net> Date: Wed, 13 May 2026 19:14:20 -0700 Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/5] hwmon: (pmbus/adm1266) replace probe-time RTC seed with rtc_class device To: Abdurrahman Hussain , Alexandru Tachici Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Belloni , linux-rtc References: <20260512-adm1266-v3-0-a81a479b0bb0@nexthop.ai> <20260512-adm1266-v3-4-a81a479b0bb0@nexthop.ai> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <20260512-adm1266-v3-4-a81a479b0bb0@nexthop.ai> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/12/26 11:56, Abdurrahman Hussain wrote: > The driver currently writes the device's internal RTC at probe with > ktime_get_seconds(), which returns CLOCK_MONOTONIC seconds since boot > and is not a wall-clock value. The resulting timestamps embedded in > blackbox records are therefore meaningless across reboots, defeating > the cross-reboot record-correlation use case the field exists for. > > Switching the seed to ktime_get_real_seconds() does not actually fix > this: at probe the system wall clock may not yet have been set (no > external RTC, no userspace NTP), and seeding unconditionally also > clobbers whatever valid time the ADM1266 retained across a warm > reboot. > > The data sheet (Rev. D, p. 22) recommends "frequently send the time > stamp to the ADM1266 to synchronize the UNIX time and reduce the time > from drifting" when running on the internal oscillator. The clean way > to expose that policy is an rtc_class device backed by SET_RTC, so > that userspace tooling (hwclock, chrony, systemd-timesyncd) can drive > the re-sync against /dev/rtcN once it trusts the system clock - with > no driver-specific sysfs ABI. > > Drop the probe-time seed and adm1266_set_rtc() entirely. Add an > rtc_class device whose ->read_time and ->set_time callbacks read and > write the SET_RTC frame. The rtc_class API is second-precision, so > the SET_RTC fractional-seconds bytes are always written as zero. > This doesn't just set the RTC time, it also acts as a real-time-clock. That seems undesirable, since it isn't really a real-time clock. It would also be the first (pseudo) rtc residing outside the rtc subsystem. It seems to me that there must be a better solution. The rtc subsystem needs to be involved in this discussion. Note - as sent separately - that making this driver dependent on the RTC subsystem (as would be required by this patch) is unacceptable. Guenter > Fixes: 15609d189302 ("hwmon: (pmbus/adm1266) read blackbox") > Signed-off-by: Abdurrahman Hussain > --- > drivers/hwmon/pmbus/adm1266.c | 78 +++++++++++++++++++++++++++++++++++-------- > 1 file changed, 65 insertions(+), 13 deletions(-) > > diff --git a/drivers/hwmon/pmbus/adm1266.c b/drivers/hwmon/pmbus/adm1266.c > index 080e7dbd0c06..05b31bb08f38 100644 > --- a/drivers/hwmon/pmbus/adm1266.c > +++ b/drivers/hwmon/pmbus/adm1266.c > @@ -18,8 +18,8 @@ > #include > #include > #include "pmbus.h" > +#include > #include > -#include > > #define ADM1266_IC_DEVICE_REV 0xAE > #define ADM1266_BLACKBOX_CONFIG 0xD3 > @@ -517,21 +517,73 @@ static int adm1266_config_nvmem(struct adm1266_data *data) > return 0; > } > > -static int adm1266_set_rtc(struct adm1266_data *data) > +/* > + * SET_RTC frame layout (datasheet Rev. D, Table 84): > + * bytes [1:0] = fractional seconds, LSB = 1/65536 s > + * bytes [5:2] = seconds since 1970-01-01 UTC > + * The rtc_class API is second-precision, so the fractional bytes are > + * always written as zero. > + */ > +static int adm1266_write_rtc(struct i2c_client *client, time64_t secs) > { > - time64_t kt; > - char write_buf[6]; > + u8 buf[6] = { 0 }; > int i; > > - kt = ktime_get_seconds(); > + for (i = 0; i < 4; i++) > + buf[2 + i] = (secs >> (i * 8)) & 0xFF; > + > + return i2c_smbus_write_block_data(client, ADM1266_SET_RTC, sizeof(buf), buf); > +} > + > +static int adm1266_rtc_read_time(struct device *dev, struct rtc_time *tm) > +{ > + struct i2c_client *client = to_i2c_client(dev); > + u8 buf[I2C_SMBUS_BLOCK_MAX]; > + u32 secs; > + int ret; > + int i; > > - memset(write_buf, 0, sizeof(write_buf)); > + guard(pmbus_lock)(client); > + ret = i2c_smbus_read_block_data(client, ADM1266_SET_RTC, buf); > + if (ret < 0) > + return ret; > + if (ret != 6) > + return -EIO; > > + secs = 0; > for (i = 0; i < 4; i++) > - write_buf[2 + i] = (kt >> (i * 8)) & 0xFF; > + secs |= (u32)buf[2 + i] << (i * 8); > + > + rtc_time64_to_tm(secs, tm); > + return 0; > +} > > - return i2c_smbus_write_block_data(data->client, ADM1266_SET_RTC, sizeof(write_buf), > - write_buf); > +static int adm1266_rtc_set_time(struct device *dev, struct rtc_time *tm) > +{ > + struct i2c_client *client = to_i2c_client(dev); > + > + guard(pmbus_lock)(client); > + return adm1266_write_rtc(client, rtc_tm_to_time64(tm)); > +} > + > +static const struct rtc_class_ops adm1266_rtc_ops = { > + .read_time = adm1266_rtc_read_time, > + .set_time = adm1266_rtc_set_time, > +}; > + > +static int adm1266_register_rtc(struct adm1266_data *data) > +{ > + struct rtc_device *rtc; > + > + rtc = devm_rtc_allocate_device(&data->client->dev); > + if (IS_ERR(rtc)) > + return PTR_ERR(rtc); > + > + rtc->ops = &adm1266_rtc_ops; > + rtc->range_min = 0; > + rtc->range_max = U32_MAX; > + > + return devm_rtc_register_device(rtc); > } > > static int adm1266_probe(struct i2c_client *client) > @@ -557,10 +609,6 @@ static int adm1266_probe(struct i2c_client *client) > if (ret < 0) > return ret; > > - ret = adm1266_set_rtc(data); > - if (ret < 0) > - return ret; > - > ret = pmbus_do_probe(client, &data->info); > if (ret) > return ret; > @@ -569,6 +617,10 @@ static int adm1266_probe(struct i2c_client *client) > if (ret < 0) > return ret; > > + ret = adm1266_register_rtc(data); > + if (ret < 0) > + return ret; > + > adm1266_init_debugfs(data); > > return 0; >