From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 470E1C38142 for ; Tue, 24 Jan 2023 11:46:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233940AbjAXLqA (ORCPT ); Tue, 24 Jan 2023 06:46:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233847AbjAXLp6 (ORCPT ); Tue, 24 Jan 2023 06:45:58 -0500 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 491713EFC7 for ; Tue, 24 Jan 2023 03:45:55 -0800 (PST) Received: by mail-pf1-x42c.google.com with SMTP id c26so11005074pfp.10 for ; Tue, 24 Jan 2023 03:45:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=C999FwRzmG6xgSAmN5RaHaFeT5++tBFM3K6nE6gR9kQ=; b=MoIu6dEpxAc7v6NG9qDlkjD5VG8dNzCd1gq2NdqSiC1Jb9EffiqLLPHC4jaCERrpmH 3B/n22ADDhlWio/1HgnHzoQa5YudgTv8QGXAhspqVq0OlUs+VOIyPoBR4Pd8VQPbVjrc +aIShkW+EnpmCOBR4hP2GUeymyCUiCD5QmKPwpZ8lwdRyQ72G3LON7klhOmZmgmTyIsh ErHZ394KZG7aDGIEg5kjDQNGzNDCcliLfcgm3EwzG+4YJd+eeXtN7YCZ3TAJe3LEItHI lTAdOEzElueEfY4igULvTyADrT/UsGfr3JDA6x8Q8OevLLO8UJWC6swfru6yVvEDiVMv V70A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C999FwRzmG6xgSAmN5RaHaFeT5++tBFM3K6nE6gR9kQ=; b=Uk2m41GuRmAvWcOVJWWU9vaAjiZ2KtLNY2MQGGqyLjvifFkUdi5N7bpmpnDjjaerPX 4sFtVj5hPZmDlHRCgPRRjxpqHq3zrwiF7orf3Z4d0uDPUuqdTjFqbe/Xvpuc3GpR0mLh bameDQfSFDFhWAN6UsqZIrtbJwFK5AAc4r21o1LJ4CfotsMIIIcNfx7rKCYEAhcjUMLb FCfm2WMKfKfZ9LrkZ6gouvnD5bi+yBQoeuCpG1spKWTA1ggzlqzDbXdaTUC9/PZwXWqk QjLz7ipeVSUk5Uieg6ew/PecgkQJ4PlNKZbZ+qJSc2awT5PR4io2QoHqJzu8MJb7jUTX T1nQ== X-Gm-Message-State: AFqh2koyerF/cNUC9l9Be+UhnIhFOvo6ro95LPHUGTvZSvIg7dIL6ut6 WvyWbpwEsi3OtRSxW2t8aUuTxw== X-Google-Smtp-Source: AMrXdXvfg2tuDxNrx7qnAFNJY/BpELo24XreajkdeWYqeU89AAQF0hM7X61io/Yz+JTaA+bHzFT6Cg== X-Received: by 2002:a05:6a00:1887:b0:58c:b0a:e504 with SMTP id x7-20020a056a00188700b0058c0b0ae504mr37927015pfh.18.1674560754594; Tue, 24 Jan 2023 03:45:54 -0800 (PST) Received: from ?IPV6:2405:201:d02f:d899:2028:7962:400:43b6? ([2405:201:d02f:d899:2028:7962:400:43b6]) by smtp.gmail.com with ESMTPSA id 76-20020a62164f000000b0058882b59d22sm1371528pfw.219.2023.01.24.03.45.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jan 2023 03:45:54 -0800 (PST) Message-ID: <05947e9f-0667-4565-b481-ca5635da4174@9elements.com> Date: Tue, 24 Jan 2023 17:15:49 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] hwmon: (pmbus/tda38640) Add driver for Infineon TDA38640 Voltage Regulator To: Krzysztof Kozlowski , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Jean Delvare Cc: linux-hwmon@vger.kernel.org, Patrick Rudolph , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230124110111.3965317-1-Naresh.Solanki@9elements.com> Content-Language: en-US From: Naresh Solanki In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Hi On 24-01-2023 04:40 pm, Krzysztof Kozlowski wrote: > On 24/01/2023 12:01, Naresh Solanki wrote: >> From: Patrick Rudolph >> >> Add the pmbus driver for the Infineon TDA38640 voltage regulator. >> >> Signed-off-by: Patrick Rudolph >> Signed-off-by: Naresh Solanki >> --- >> .../devicetree/bindings/trivial-devices.yaml | 2 + > > Split bindings from driver code. Sure > >> drivers/hwmon/pmbus/Kconfig | 16 ++++ >> drivers/hwmon/pmbus/Makefile | 1 + >> drivers/hwmon/pmbus/tda38640.c | 78 +++++++++++++++++++ >> 4 files changed, 97 insertions(+) >> create mode 100644 drivers/hwmon/pmbus/tda38640.c >> >> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml >> index f5c0a6283e61..a28b02036489 100644 >> --- a/Documentation/devicetree/bindings/trivial-devices.yaml >> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml >> @@ -141,6 +141,8 @@ properties: >> - infineon,slb9645tt >> # Infineon SLB9673 I2C TPM 2.0 >> - infineon,slb9673 >> + # Infineon TDA38640 Voltage Regulator >> + - infineon,tda38640 >> # Infineon TLV493D-A1B6 I2C 3D Magnetic Sensor >> - infineon,tlv493d-a1b6 >> # Infineon Multi-phase Digital VR Controller xdpe11280 >> diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig >> index 30448e049486..9f4bbb9c487a 100644 >> --- a/drivers/hwmon/pmbus/Kconfig >> +++ b/drivers/hwmon/pmbus/Kconfig >> @@ -395,6 +395,22 @@ config SENSORS_STPDDC60 >> This driver can also be built as a module. If so, the module will >> be called stpddc60. >> >> +config SENSORS_TDA38640 >> + tristate "Infineon TDA38640" >> + help >> + If you say yes here you get hardware monitoring support for Infineon >> + TDA38640. >> + >> + This driver can also be built as a module. If so, the module will >> + be called tda38640. >> + >> +config SENSORS_TDA38640_REGULATOR >> + bool "Regulator support for TDA38640 and compatibles" >> + depends on SENSORS_TDA38640 && REGULATOR >> + help >> + If you say yes here you get regulator support for Infineon >> + TDA38640 as regulator. > > Drop entire option, why is it needed? You mean regulator option ? This is how other pmbus regulator devices have provided option. > >> + >> config SENSORS_TPS40422 >> tristate "TI TPS40422" >> help >> diff --git a/drivers/hwmon/pmbus/Makefile b/drivers/hwmon/pmbus/Makefile >> index d9d2fa4bd6f7..3ae019916267 100644 >> --- a/drivers/hwmon/pmbus/Makefile >> +++ b/drivers/hwmon/pmbus/Makefile >> @@ -40,6 +40,7 @@ obj-$(CONFIG_SENSORS_PM6764TR) += pm6764tr.o >> obj-$(CONFIG_SENSORS_PXE1610) += pxe1610.o >> obj-$(CONFIG_SENSORS_Q54SJ108A2) += q54sj108a2.o >> obj-$(CONFIG_SENSORS_STPDDC60) += stpddc60.o >> +obj-$(CONFIG_SENSORS_TDA38640) += tda38640.o >> obj-$(CONFIG_SENSORS_TPS40422) += tps40422.o >> obj-$(CONFIG_SENSORS_TPS53679) += tps53679.o >> obj-$(CONFIG_SENSORS_TPS546D24) += tps546d24.o >> diff --git a/drivers/hwmon/pmbus/tda38640.c b/drivers/hwmon/pmbus/tda38640.c >> new file mode 100644 >> index 000000000000..31e17a936b8c >> --- /dev/null >> +++ b/drivers/hwmon/pmbus/tda38640.c >> @@ -0,0 +1,78 @@ >> +// SPDX-License-Identifier: GPL-2.0+ >> +/* >> + * Hardware monitoring driver for Infineon TDA38640 >> + * >> + * Copyright (c) 2023 9elements GmbH >> + * >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include "pmbus.h" >> + >> +#if IS_ENABLED(CONFIG_SENSORS_TDA38640_REGULATOR) >> +static const struct regulator_desc tda38640_reg_desc[] = { >> + PMBUS_REGULATOR("vout", 0), >> +}; >> +#endif /* CONFIG_SENSORS_TDA38640_REGULATOR */ >> + >> +static struct pmbus_driver_info tda38640_info = { >> + .pages = 1, >> + .format[PSC_VOLTAGE_IN] = linear, >> + .format[PSC_VOLTAGE_OUT] = linear, >> + .format[PSC_CURRENT_OUT] = linear, >> + .format[PSC_CURRENT_IN] = linear, >> + .format[PSC_POWER] = linear, >> + .format[PSC_TEMPERATURE] = linear, >> + >> + .func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_STATUS_INPUT >> + | PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP >> + | PMBUS_HAVE_IIN >> + | PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT >> + | PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT >> + | PMBUS_HAVE_POUT | PMBUS_HAVE_PIN, >> +#if IS_ENABLED(CONFIG_SENSORS_TDA38640_REGULATOR) >> + .num_regulators = 1, >> + .reg_desc = tda38640_reg_desc, >> +#endif >> +}; >> + >> +static int tda38640_probe(struct i2c_client *client) >> +{ >> + return pmbus_do_probe(client, &tda38640_info); >> +} >> + >> +static const struct i2c_device_id tda38640_id[] = { >> + {"tda38640", 0}, >> + {} >> +}; >> + > > Drop blank line Sure > >> +MODULE_DEVICE_TABLE(i2c, tda38640_id); >> + >> +#ifdef CONFIG_OF > > Drop ifdefs and use __maybe_unused > >> +static const struct of_device_id tda38640_of_match[] = { >> + { .compatible = "infineon,tda38640"}, >> + { }, >> +}; >> +MODULE_DEVICE_TABLE(of, tda38640_of_match); > > Where is it used? You miss the user. I'm not sure if I get your question right. This chip is used in sbp1 board to power CPU rails. > >> +#endif >> + >> +/* This is the driver that will be inserted */ >> +static struct i2c_driver tda38640_driver = { >> + .driver = { >> + .name = "tda38640", >> + }, >> + .probe_new = tda38640_probe, >> + .id_table = tda38640_id, >> +}; > > Best regards, > Krzysztof > Best regards, Naresh