From: Quentin Schulz <quentin.schulz@cherry.de>
To: Guenter Roeck <linux@roeck-us.net>, linux-hwmon@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Farouk Bouabid <farouk.bouabid@cherry.de>
Subject: Re: [PATCH 03/10] hwmon: (amc6821) Rename fan1_div to fan1_pulses
Date: Mon, 1 Jul 2024 13:08:36 +0200 [thread overview]
Message-ID: <05e2dfa6-ea35-4600-94a3-6b182635434f@cherry.de> (raw)
In-Reply-To: <20240628151346.1152838-4-linux@roeck-us.net>
Hi Guenter,
On 6/28/24 5:13 PM, Guenter Roeck wrote:
> The chip does not have a fan divisor. What it does have is a configuration
> to set either 2 or 4 pulses per fan rotation. Rename the attribute to
> reflect its use. Update documentation accordingly.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Good catch!
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Thanks,
Quentin
next prev parent reply other threads:[~2024-07-01 11:08 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 15:13 [PATCH 00/10] hwmon: (amc6821) Various improvements Guenter Roeck
2024-06-28 15:13 ` [PATCH 01/10] hwmon: (amc6821) Stop accepting invalid pwm values Guenter Roeck
2024-07-01 10:19 ` Quentin Schulz
2024-07-01 13:50 ` Guenter Roeck
2024-06-28 15:13 ` [PATCH 02/10] hwmon: (amc6821) Make reading and writing fan speed limits consistent Guenter Roeck
2024-07-01 11:05 ` Quentin Schulz
2024-07-01 14:11 ` Guenter Roeck
2024-07-01 14:37 ` Guenter Roeck
2024-07-01 16:13 ` Quentin Schulz
2024-07-01 17:21 ` Guenter Roeck
2024-07-01 18:05 ` Quentin Schulz
2024-07-01 19:11 ` Guenter Roeck
2024-06-28 15:13 ` [PATCH 03/10] hwmon: (amc6821) Rename fan1_div to fan1_pulses Guenter Roeck
2024-07-01 11:08 ` Quentin Schulz [this message]
2024-06-28 15:13 ` [PATCH 04/10] hwmon: (amc6821) Add support for fan1_target and pwm1_enable mode 4 Guenter Roeck
2024-07-01 11:23 ` Quentin Schulz
2024-07-01 15:26 ` Guenter Roeck
2024-07-01 16:29 ` Quentin Schulz
2024-07-01 17:31 ` Guenter Roeck
2024-06-28 15:13 ` [PATCH 05/10] hwmon: (amc2821) Reorder include files, drop unnecessary ones Guenter Roeck
2024-07-01 11:24 ` Quentin Schulz
2024-06-28 15:13 ` [PATCH 06/10] hwmon: (amc6821) Use tabs for column alignment in defines Guenter Roeck
2024-07-01 11:26 ` Quentin Schulz
2024-06-28 15:13 ` [PATCH 07/10] hwmon: (amc2821) Use BIT() and GENMASK() Guenter Roeck
2024-07-01 11:31 ` Quentin Schulz
2024-07-01 14:44 ` Guenter Roeck
2024-06-28 15:13 ` [PATCH 08/10] hwmon: (amc6821) Drop unnecessary enum chips Guenter Roeck
2024-07-01 11:36 ` Quentin Schulz
2024-07-01 14:47 ` Guenter Roeck
2024-06-28 15:13 ` [PATCH 09/10] hwmon: (amc6821) Convert to use regmap Guenter Roeck
2024-07-01 13:01 ` Quentin Schulz
2024-07-01 13:47 ` Guenter Roeck
2024-07-01 16:54 ` Quentin Schulz
2024-07-01 17:30 ` Guenter Roeck
2024-06-28 15:13 ` [PATCH 10/10] hwmon: (amc6821) Convert to with_info API Guenter Roeck
2024-07-01 17:46 ` Quentin Schulz
2024-07-01 18:24 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05e2dfa6-ea35-4600-94a3-6b182635434f@cherry.de \
--to=quentin.schulz@cherry.de \
--cc=farouk.bouabid@cherry.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox