From: Andrei Lalaev <andrey.lalaev@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>,
jdelvare@suse.com, conor+dt@kernel.org, robh@kernel.org,
krzk@kernel.org, christophe.jaillet@wanadoo.fr
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] hwmon: add driver for HTU31
Date: Sun, 26 Jan 2025 20:16:01 +0100 [thread overview]
Message-ID: <0e003860-004c-4004-ad13-36c77e1b8378@gmail.com> (raw)
In-Reply-To: <1f76d87e-cf99-4114-bb3f-d812bbc5b45f@roeck-us.net>
On 26.01.2025 15:59, Guenter Roeck wrote:
> On 1/26/25 06:40, Andrei Lalaev wrote:
>> Add base support for HTU31 temperature and humidity sensor.
>>
>> Besides temperature and humidity values, the driver also exports a 24-bit
>> serial number and heater control to sysfs.
>>
>> Signed-off-by: Andrei Lalaev <andrey.lalaev@gmail.com>
>> ---
> ...
>> +
>> +static struct attribute *htu31_attrs[] = {
>> + &dev_attr_heater_enable.attr,
>> + &dev_attr_serial_number.attr,
>
> I'll accept the heater enable attribute as sysfs attribute,
> but the serial number is most definitely not a hardware monitoring
> attribute. Please expose is through debugfs.
It makes sense. Will be moved to debugfs in v3.
Thank you!
Best regards,
Andrei Lalaev
next prev parent reply other threads:[~2025-01-26 19:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-26 14:40 [PATCH v2 0/2] Add driver for HTU31 Andrei Lalaev
2025-01-26 14:40 ` [PATCH 1/2] hwmon: add " Andrei Lalaev
2025-01-26 14:59 ` Guenter Roeck
2025-01-26 19:16 ` Andrei Lalaev [this message]
2025-01-26 19:36 ` Guenter Roeck
2025-01-26 14:40 ` [PATCH 2/2] dt-bindings: hwmon: Add description for sensor HTU31 Andrei Lalaev
2025-01-27 7:07 ` Krzysztof Kozlowski
2025-01-27 19:21 ` Andrei Lalaev
2025-01-27 19:39 ` Krzysztof Kozlowski
2025-01-27 20:14 ` Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2025-01-23 20:25 [PATCH 0/2] Add driver for HTU31 Andrei Lalaev
2025-01-23 20:25 ` [PATCH 1/2] hwmon: add " Andrei Lalaev
2025-01-24 8:31 ` Krzysztof Kozlowski
2025-01-24 14:56 ` Andrei Lalaev
2025-01-27 12:16 ` Krzysztof Kozlowski
2025-01-24 12:14 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e003860-004c-4004-ad13-36c77e1b8378@gmail.com \
--to=andrey.lalaev@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox