Re: [PATCH v3 5/5] hwmon: (pmbus/adm1266) include adapter number in GPIO line label

[Guenter Roeck <linux@roeck-us.net>]

On Tue, May 12, 2026 at 11:56:28AM -0700, Abdurrahman Hussain wrote:
> Platforms that fit more than one ADM1266 on different I2C buses at
> the same 7-bit slave address (a common shelf-management pattern,
> e.g. one device per power domain) end up with duplicate GPIO line
> labels because the existing format only includes the slave address.
> Including the adapter number disambiguates them.
> 
> The adapter number is formatted as decimal to match the i2c-N
> convention used elsewhere in Linux (sysfs paths, dev nodes); the
> slave address keeps its conventional hexadecimal form.
> 
> The label is purely informational (visible via gpioinfo and the
> gpiochip /sys/class/gpio name); no DT or ABI consumer parses it.
> 
> Signed-off-by: Abdurrahman Hussain <abdurrahman@nexthop.ai>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/pmbus/adm1266.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/pmbus/adm1266.c b/drivers/hwmon/pmbus/adm1266.c
> index 05b31bb08f38..12cdf6de341a 100644
> --- a/drivers/hwmon/pmbus/adm1266.c
> +++ b/drivers/hwmon/pmbus/adm1266.c
> @@ -292,8 +292,9 @@ static int adm1266_config_gpio(struct adm1266_data *data)
>  	int i;
>  
>  	for (i = 0; i < ARRAY_SIZE(data->gpio_names); i++) {
> -		gpio_name = devm_kasprintf(&data->client->dev, GFP_KERNEL, "adm1266-%x-%s",
> -					   data->client->addr, adm1266_names[i]);
> +		gpio_name = devm_kasprintf(&data->client->dev, GFP_KERNEL, "adm1266-%d-%x-%s",
> +					   data->client->adapter->nr, data->client->addr,
> +					   adm1266_names[i]);
>  		if (!gpio_name)
>  			return -ENOMEM;
>