Re: [PATCH v6 2/2] dt-bindings: hwmon: isl68137: add bindings to support voltage dividers

[Guenter Roeck <linux@roeck-us.net>]

On 11/4/24 07:08, Rob Herring wrote:
> On Wed, Oct 30, 2024 at 5:41 PM Grant Peltier <grantpeltier93@gmail.com> wrote:
>>
>> Add devicetree bindings to support declaring optional voltage dividers to
>> the rail outputs of supported digital multiphase regulators. Some
>> applications require Vout to exceed the voltage range that the Vsense pin
>> can detect. This binding definition allows users to define the
>> characteristics of a voltage divider placed between Vout and the Vsense
>> pin for any rail powered by the device.
>>
>> These bindings copy the vout-voltage-divider property defined in the
>> maxim,max20730 bindings schema since it is the best fit for the use case
>> of scaling hwmon PMBus telemetry. The generic voltage-divider property
>> used by many iio drivers was determined to be a poor fit because that
>> schema is tied directly to iio for the purpose of scaling io-channel
>> voltages and the isl68137 driver is not an iio driver.
>>
>> Signed-off-by: Grant Peltier <grantpeltier93@gmail.com>
>> ---
>>   .../hwmon/pmbus/renesas,isl68137.yaml         | 147 ++++++++++++++++++
>>   1 file changed, 147 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/renesas,isl68137.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/renesas,isl68137.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/renesas,isl68137.yaml
>> new file mode 100644
>> index 000000000000..ed659c2baadf
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/renesas,isl68137.yaml
>> @@ -0,0 +1,147 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +
>> +$id: http://devicetree.org/schemas/hwmon/pmbus/renesas,isl68137.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Renesas Digital Multiphase Voltage Regulators with PMBus
>> +
>> +maintainers:
>> +  - Grant Peltier <grant.peltier.jg@renesas.com>
>> +
>> +description: |
>> +  Renesas digital multiphase voltage regulators with PMBus.
>> +  https://www.renesas.com/en/products/power-management/multiphase-power/multiphase-dcdc-switching-controllers
>> +
>> +properties:
>> +  compatible:
>> +    enum:
> 
> Somehow "isl68137" is missing from your list. "make
> dt_compatible_check" reports it as not documented.
> 

Turns out it is also documented as "isil,isl68137" in trivial-devices.yaml
(together with isil,isl69260). Both are referenced in .dts files. How should
that be handled ?

Thanks,
Guenter

>> +      - renesas,isl68220
>> +      - renesas,isl68221
>> +      - renesas,isl68222
>> +      - renesas,isl68223
>> +      - renesas,isl68224
>> +      - renesas,isl68225
>> +      - renesas,isl68226
>> +      - renesas,isl68227
>> +      - renesas,isl68229
>> +      - renesas,isl68233
>> +      - renesas,isl68239
>> +      - renesas,isl69222
>> +      - renesas,isl69223
>> +      - renesas,isl69224
>> +      - renesas,isl69225
>> +      - renesas,isl69227
>> +      - renesas,isl69228
>> +      - renesas,isl69234
>> +      - renesas,isl69236
>> +      - renesas,isl69239
>> +      - renesas,isl69242
>> +      - renesas,isl69243
>> +      - renesas,isl69247
>> +      - renesas,isl69248
>> +      - renesas,isl69254
>> +      - renesas,isl69255
>> +      - renesas,isl69256
>> +      - renesas,isl69259
>> +      - renesas,isl69260
>> +      - renesas,isl69268
>> +      - renesas,isl69269
>> +      - renesas,isl69298
>> +      - renesas,raa228000
>> +      - renesas,raa228004
>> +      - renesas,raa228006
>> +      - renesas,raa228228
>> +      - renesas,raa229001
>> +      - renesas,raa229004