From: Guenter Roeck <linux@roeck-us.net>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org,
Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org
Subject: Re: [RFC PATCH v2] hwmon: (lm75) add I3C support for P3T1755
Date: Fri, 20 Dec 2024 07:02:03 -0800 [thread overview]
Message-ID: <103fcb15-e550-4d3d-a243-ea3ccf98e76b@roeck-us.net> (raw)
In-Reply-To: <20241220093635.11218-1-wsa+renesas@sang-engineering.com>
On Fri, Dec 20, 2024 at 10:36:34AM +0100, Wolfram Sang wrote:
> Introduce I3C support by defining I3C accessors for regmap and
> implementing an I3C driver. Enable I3C for the NXP P3T1755.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Changes since v1:
> * don't parse i2c_device_id for a suitable sensor name but copy this
> information to a specific struct for I3C devices
> (frankly, I liked the previous solution better)
>
> * not really a change. I decided against using cpu_to_be/le* helpers.
> It looks clumsy when operating on an array of u8 with them IMHO.
>
Should I apply this patch as-is, or do you want to send another version
using {ge,pu}t_unaligned_[bl]e*() ? Either way is fine with me.
Thanks,
Guenter
next prev parent reply other threads:[~2024-12-20 15:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-20 9:36 [RFC PATCH v2] hwmon: (lm75) add I3C support for P3T1755 Wolfram Sang
2024-12-20 9:54 ` Geert Uytterhoeven
2024-12-20 10:12 ` Wolfram Sang
2024-12-20 15:02 ` Guenter Roeck [this message]
2024-12-22 13:02 ` Wolfram Sang
2024-12-22 15:18 ` Guenter Roeck
2024-12-22 17:00 ` Wolfram Sang
2024-12-22 17:21 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=103fcb15-e550-4d3d-a243-ea3ccf98e76b@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox