Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>,
	Sasha Levin <sashal@kernel.org>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: jdelvare@suse.com, corbet@lwn.net, linux-hwmon@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 5.17 128/135] hwmon: Make chip parameter for with_info API mandatory
Date: Tue, 31 May 2022 09:38:03 +0700	[thread overview]
Message-ID: <1344ac58-f019-03ef-fab8-6e1d910514e2@gmail.com> (raw)
In-Reply-To: <dddc2b53-62eb-fda7-4425-afdd179a7037@roeck-us.net>

On 5/30/22 21:27, Guenter Roeck wrote:
> On 5/30/22 06:31, Sasha Levin wrote:
>> From: Guenter Roeck <linux@roeck-us.net>
>>
>> [ Upstream commit ddaefa209c4ac791c1262e97c9b2d0440c8ef1d5 ]
>>
>> Various attempts were made recently to "convert" the old
>> hwmon_device_register() API to devm_hwmon_device_register_with_info()
>> by just changing the function name without actually converting the
>> driver. Prevent this from happening by making the 'chip' parameter of
>> devm_hwmon_device_register_with_info() mandatory.
>>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
> 
> This patch should not be backported. It is only relevant for new
> kernel releases, and may have adverse affect if applied to older
> kernels.

So this patch is meant to be backported to 5.18 only, right?

-- 
An old man doll... just what I always wanted! - Clara

  reply	other threads:[~2022-05-31  2:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220530133133.1931716-1-sashal@kernel.org>
2022-05-30 13:31 ` [PATCH AUTOSEL 5.17 128/135] hwmon: Make chip parameter for with_info API mandatory Sasha Levin
2022-05-30 14:27   ` Guenter Roeck
2022-05-31  2:38     ` Bagas Sanjaya [this message]
2022-05-31  3:00       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1344ac58-f019-03ef-fab8-6e1d910514e2@gmail.com \
    --to=bagasdotme@gmail.com \
    --cc=corbet@lwn.net \
    --cc=jdelvare@suse.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox