Re: [PATCH] added kernel module for FTS sensor chip "Teutates"

["thilo.cestonaro@ts.fujitsu.com" <thilo.cestonaro@ts.fujitsu.com>]

[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]

Hey Guenter,

> > +static int ftsteutates_detect(struct i2c_client *client,
> > +		struct i2c_board_info *info)
> > +{
> > +	int val = ftsteutates_read_byte(client, FTSTEUTATES_DEVICE_ID_REG);
> > +
> > +	/* Baseboard Management Controller */
> > +	if ((val & 0xF0) == 0x10) {
> > +		switch (val & 0x0F) {
> > +		case 0x01:
> > +			strlcpy(info->type, ftsteutates_id[teutates].name,
> > +			I2C_NAME_SIZE);
> > +			info->flags = 0;
> > +			return 0;
> > +		}
> > +	}
> This is not sufficient for a detect function; it would result in many false
> positives. Please drop it unless a much better means to detect the chip
> is available.
> 
Would it be sufficient, if I use dmi_name_in_vendors and check for Fujitsu? So the 
BMC check will only be used on FJ Boards?

The problem is, that the firmware itself has only this device ID register.
For future revisions I'll ask for more possibilities to identify the chip but for now
I need to use other methods.

Cheers,
Thilo

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3847 bytes --]