From: Matt Ranostay <mranostay@gmail.com>
To: linux-hwmon@vger.kernel.org
Cc: Matt Ranostay <mranostay@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
David Frey <david.frey@sensirion.com>
Subject: [PATCH] hwmon: sht3x: set initial jiffies to last_update
Date: Thu, 7 Jul 2016 19:46:11 -0700 [thread overview]
Message-ID: <1467945971-23798-1-git-send-email-mranostay@gmail.com> (raw)
Handling the wraparound requires the data->last_update to be set to an
initial jiffies value. Otherwise you can start in a state where the
sensor will never request a reading.
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: David Frey <david.frey@sensirion.com>
Signed-off-by: Matt Ranostay <mranostay@gmail.com>
---
drivers/hwmon/sht3x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/sht3x.c b/drivers/hwmon/sht3x.c
index 450645b6053d..05a925257938 100644
--- a/drivers/hwmon/sht3x.c
+++ b/drivers/hwmon/sht3x.c
@@ -722,7 +722,7 @@ static int sht3x_probe(struct i2c_client *client,
data->setup.blocking_io = false;
data->setup.high_precision = true;
data->mode = 0;
- data->last_update = 0;
+ data->last_update = jiffies;
data->client = client;
crc8_populate_msb(sht3x_crc8_table, SHT3X_CRC8_POLYNOMIAL);
--
2.7.4
next reply other threads:[~2016-07-08 2:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 2:46 Matt Ranostay [this message]
2016-07-08 7:56 ` [PATCH] hwmon: sht3x: set initial jiffies to last_update Jean Delvare
2016-07-09 0:22 ` Matt Ranostay
2016-07-21 6:10 ` Jean Delvare
2016-07-24 23:50 ` Matt Ranostay
2016-07-25 8:42 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467945971-23798-1-git-send-email-mranostay@gmail.com \
--to=mranostay@gmail.com \
--cc=david.frey@sensirion.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox