* [PATCH v2] hwmon: (sht3x) set initial jiffies to last_update
@ 2016-07-25 0:05 Matt Ranostay
2016-07-25 8:49 ` Jean Delvare
2016-07-25 14:42 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Matt Ranostay @ 2016-07-25 0:05 UTC (permalink / raw)
To: linux-hwmon; +Cc: jdelvare, Matt Ranostay, Guenter Roeck, David Frey
Handling the wraparound requires the data->last_update to be set to an
initial jiffies value. Otherwise on 32-bit systems you will not be able
to request a reading till the 5 minute jiffies rollover happens.
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: David Frey <david.frey@sensirion.com>
Signed-off-by: Matt Ranostay <mranostay@gmail.com>
---
Changes from v1:
* document more in commit message the reason for the patch
* mark last sample before driver load so initial reading can happen
shortly after boot
drivers/hwmon/sht3x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/sht3x.c b/drivers/hwmon/sht3x.c
index b73a48832732..6ea99cd6ae79 100644
--- a/drivers/hwmon/sht3x.c
+++ b/drivers/hwmon/sht3x.c
@@ -720,7 +720,7 @@ static int sht3x_probe(struct i2c_client *client,
data->setup.blocking_io = false;
data->setup.high_precision = true;
data->mode = 0;
- data->last_update = 0;
+ data->last_update = jiffies - msecs_to_jiffies(3000);
data->client = client;
crc8_populate_msb(sht3x_crc8_table, SHT3X_CRC8_POLYNOMIAL);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] hwmon: (sht3x) set initial jiffies to last_update
2016-07-25 0:05 [PATCH v2] hwmon: (sht3x) set initial jiffies to last_update Matt Ranostay
@ 2016-07-25 8:49 ` Jean Delvare
2016-07-25 14:42 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2016-07-25 8:49 UTC (permalink / raw)
To: Matt Ranostay; +Cc: linux-hwmon, Guenter Roeck, David Frey
On Sun, 24 Jul 2016 17:05:32 -0700, Matt Ranostay wrote:
> Handling the wraparound requires the data->last_update to be set to an
> initial jiffies value. Otherwise on 32-bit systems you will not be able
> to request a reading till the 5 minute jiffies rollover happens.
>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: David Frey <david.frey@sensirion.com>
> Signed-off-by: Matt Ranostay <mranostay@gmail.com>
> ---
>
> Changes from v1:
> * document more in commit message the reason for the patch
> * mark last sample before driver load so initial reading can happen
> shortly after boot
>
> drivers/hwmon/sht3x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/sht3x.c b/drivers/hwmon/sht3x.c
> index b73a48832732..6ea99cd6ae79 100644
> --- a/drivers/hwmon/sht3x.c
> +++ b/drivers/hwmon/sht3x.c
> @@ -720,7 +720,7 @@ static int sht3x_probe(struct i2c_client *client,
> data->setup.blocking_io = false;
> data->setup.high_precision = true;
> data->mode = 0;
> - data->last_update = 0;
> + data->last_update = jiffies - msecs_to_jiffies(3000);
> data->client = client;
> crc8_populate_msb(sht3x_crc8_table, SHT3X_CRC8_POLYNOMIAL);
>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] hwmon: (sht3x) set initial jiffies to last_update
2016-07-25 0:05 [PATCH v2] hwmon: (sht3x) set initial jiffies to last_update Matt Ranostay
2016-07-25 8:49 ` Jean Delvare
@ 2016-07-25 14:42 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2016-07-25 14:42 UTC (permalink / raw)
To: Matt Ranostay, linux-hwmon; +Cc: jdelvare, David Frey
On 07/24/2016 05:05 PM, Matt Ranostay wrote:
> Handling the wraparound requires the data->last_update to be set to an
> initial jiffies value. Otherwise on 32-bit systems you will not be able
> to request a reading till the 5 minute jiffies rollover happens.
>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: David Frey <david.frey@sensirion.com>
> Signed-off-by: Matt Ranostay <mranostay@gmail.com>
Applied.
Thanks,
Guenter
> ---
>
> Changes from v1:
> * document more in commit message the reason for the patch
> * mark last sample before driver load so initial reading can happen
> shortly after boot
>
> drivers/hwmon/sht3x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/sht3x.c b/drivers/hwmon/sht3x.c
> index b73a48832732..6ea99cd6ae79 100644
> --- a/drivers/hwmon/sht3x.c
> +++ b/drivers/hwmon/sht3x.c
> @@ -720,7 +720,7 @@ static int sht3x_probe(struct i2c_client *client,
> data->setup.blocking_io = false;
> data->setup.high_precision = true;
> data->mode = 0;
> - data->last_update = 0;
> + data->last_update = jiffies - msecs_to_jiffies(3000);
> data->client = client;
> crc8_populate_msb(sht3x_crc8_table, SHT3X_CRC8_POLYNOMIAL);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-25 14:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-25 0:05 [PATCH v2] hwmon: (sht3x) set initial jiffies to last_update Matt Ranostay
2016-07-25 8:49 ` Jean Delvare
2016-07-25 14:42 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox