* [PATCH] hwmon: (lm90) Add missing assignment
@ 2016-07-25 21:50 Guenter Roeck
2016-07-26 7:21 ` Jean Delvare
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2016-07-25 21:50 UTC (permalink / raw)
To: Hardware Monitoring; +Cc: Jean Delvare, Guenter Roeck
Coverity reports the following error.
>>> CID 1364474: Error handling issues (CHECKED_RETURN)
>>> Calling "lm90_read_reg" without checking return value (as is done
>>> elsewhere 28 out of 29 times).
532 lm90_read_reg(client, LM90_REG_R_REMOTE_LOWH);
533 if (val < 0)
534 return val;
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/hwmon/lm90.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c
index f51e758ba529..7b3eedf76c62 100644
--- a/drivers/hwmon/lm90.c
+++ b/drivers/hwmon/lm90.c
@@ -529,7 +529,7 @@ static int lm90_update_limits(struct device *dev)
return val;
data->temp_hyst = val;
- lm90_read_reg(client, LM90_REG_R_REMOTE_LOWH);
+ val = lm90_read_reg(client, LM90_REG_R_REMOTE_LOWH);
if (val < 0)
return val;
data->temp11[REMOTE_LOW] = val << 8;
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon: (lm90) Add missing assignment
2016-07-25 21:50 [PATCH] hwmon: (lm90) Add missing assignment Guenter Roeck
@ 2016-07-26 7:21 ` Jean Delvare
0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2016-07-26 7:21 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Hardware Monitoring
Hi Guenter,
On Mon, 25 Jul 2016 14:50:41 -0700, Guenter Roeck wrote:
> Coverity reports the following error.
>
> >>> CID 1364474: Error handling issues (CHECKED_RETURN)
> >>> Calling "lm90_read_reg" without checking return value (as is done
> >>> elsewhere 28 out of 29 times).
> 532 lm90_read_reg(client, LM90_REG_R_REMOTE_LOWH);
> 533 if (val < 0)
> 534 return val;
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/hwmon/lm90.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c
> index f51e758ba529..7b3eedf76c62 100644
> --- a/drivers/hwmon/lm90.c
> +++ b/drivers/hwmon/lm90.c
> @@ -529,7 +529,7 @@ static int lm90_update_limits(struct device *dev)
> return val;
> data->temp_hyst = val;
>
> - lm90_read_reg(client, LM90_REG_R_REMOTE_LOWH);
> + val = lm90_read_reg(client, LM90_REG_R_REMOTE_LOWH);
> if (val < 0)
> return val;
> data->temp11[REMOTE_LOW] = val << 8;
Good catch.
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-26 7:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-25 21:50 [PATCH] hwmon: (lm90) Add missing assignment Guenter Roeck
2016-07-26 7:21 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox