From: Andrew Jeffery <andrew@aj.id.au>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, jdelvare@suse.com,
linux-doc@vger.kernel.org, openbmc@lists.ozlabs.org,
corbet@lwn.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors
Date: Fri, 08 Sep 2017 15:16:16 +1000 [thread overview]
Message-ID: <1504847776.6124.17.camel@aj.id.au> (raw)
In-Reply-To: <a9924f0c-ee26-6c6b-262e-84dacb50b6a6@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
On Thu, 2017-09-07 at 22:14 -0700, Guenter Roeck wrote:
> On 09/07/2017 08:40 PM, Andrew Jeffery wrote:
> > On Fri, 2017-09-08 at 12:51 +1000, Andrew Jeffery wrote:
> > > > I can't test with devicetree. x86 system.
> > > >
> > > > 2,100+ iterations with your driver, no failures.
> > >
> > > Great. I really appreciate your testing here, so thanks for your
> > > efforts. I owe you a few drinks if we ever happen to meet.
> >
> > Actually, on that, how did you chop out the devicetree parts? Did you
> > keep the configuration writes at the end of max31785_of_fan_config()
> > and max31785_of_tmp_config()? Or did you just not call them? These two
> > functions cause the bulk of the bus traffic with on probe.
> >
>
> fan config hardcoded, four fans connected. Still no failure.
Great. Thanks again for your efforts here.
Andrew
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2017-09-08 5:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 7:01 [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors Andrew Jeffery
2017-09-05 17:00 ` Guenter Roeck
2017-09-06 0:23 ` Andrew Jeffery
2017-09-06 22:51 ` Guenter Roeck
2017-09-06 23:32 ` Andrew Jeffery
2017-09-07 2:19 ` Guenter Roeck
2017-09-07 13:40 ` Guenter Roeck
2017-09-07 15:22 ` Andrew Jeffery
2017-09-08 0:27 ` Guenter Roeck
2017-09-08 1:02 ` Andrew Jeffery
2017-09-08 1:26 ` Guenter Roeck
2017-09-08 2:06 ` Andrew Jeffery
2017-09-08 2:17 ` Guenter Roeck
2017-09-08 2:51 ` Andrew Jeffery
2017-09-08 3:40 ` Andrew Jeffery
2017-09-08 4:43 ` Guenter Roeck
2017-09-08 5:08 ` Andrew Jeffery
2017-09-08 5:14 ` Guenter Roeck
2017-09-08 5:16 ` Andrew Jeffery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504847776.6124.17.camel@aj.id.au \
--to=andrew@aj.id.au \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox