From: "Rob Herring (Arm)" <robh@kernel.org>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: linux-hwmon@vger.kernel.org, conor+dt@kernel.org,
linux@roeck-us.net, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org, krzk+dt@kernel.org,
ukleinek@kernel.org, devicetree@vger.kernel.org,
jdelvare@suse.com
Subject: Re: [PATCH v5 1/3] dt-bindings: hwmon: Add adt7475 fan/pwm properties
Date: Mon, 15 Jul 2024 06:17:42 -0600 [thread overview]
Message-ID: <172104586129.3775717.7588578554384809361.robh@kernel.org> (raw)
In-Reply-To: <20240711234614.3104839-2-chris.packham@alliedtelesis.co.nz>
On Fri, 12 Jul 2024 11:46:12 +1200, Chris Packham wrote:
> Add fan child nodes that allow describing the connections for the
> ADT7475 to the fans it controls. This also allows setting some
> initial values for the pwm duty cycle and frequency.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
>
> Notes:
> Changes in v5:
> - Use nanoseconds for PWM frequency and duty cycle as per existing
> conventions for PWMs
> - Set flags to 0 in example to match adi,pwm-active-state setting
> Changes in v4:
> - 0 is not a valid frequency value
> Changes in v3:
> - Use the pwm provider/consumer bindings
> Changes in v2:
> - Document 0 as a valid value (leaves hardware as-is)
>
> .../devicetree/bindings/hwmon/adt7475.yaml | 35 ++++++++++++++++++-
> 1 file changed, 34 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
next prev parent reply other threads:[~2024-07-15 12:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 23:46 [PATCH v5 0/3] hwmon: (adt7475) duty cycle configuration Chris Packham
2024-07-11 23:46 ` [PATCH v5 1/3] dt-bindings: hwmon: Add adt7475 fan/pwm properties Chris Packham
2024-07-15 12:17 ` Rob Herring (Arm) [this message]
2024-07-11 23:46 ` [PATCH v5 2/3] dt-bindings: hwmon: adt7475: Deprecate adi,pwm-active-state Chris Packham
2024-07-11 23:46 ` [PATCH v5 3/3] hwmon: (adt7475) Add support for configuring initial PWM state Chris Packham
2024-07-12 4:37 ` Guenter Roeck
2024-07-12 5:24 ` Uwe Kleine-König
2024-07-12 12:45 ` kernel test robot
2024-07-12 16:34 ` Uwe Kleine-König
2024-07-12 17:29 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172104586129.3775717.7588578554384809361.robh@kernel.org \
--to=robh@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox