From: Joe Perches <joe@perches.com>
To: Corentin Labbe <clabbe@baylibre.com>,
jdelvare@suse.com, linux@roeck-us.net
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] hwmon: Remove multiple space after dot
Date: Sat, 01 Dec 2018 12:27:18 -0800 [thread overview]
Message-ID: <188e822951d0b3a30cf4eea8ec0ea7b6d3bb4fca.camel@perches.com> (raw)
In-Reply-To: <1543522155-17406-2-git-send-email-clabbe@baylibre.com>
On Thu, 2018-11-29 at 20:09 +0000, Corentin Labbe wrote:
> This patch remove extra space after a dot.
[]
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
---
> drivers/hwmon/Kconfig | 236 +++++++++++++++++++++---------------------
> 1 file changed, 118 insertions(+), 118 deletions(-)
[]
> @@ -11,7 +11,7 @@ menuconfig HWMON
> of a system. Most modern motherboards include such a device. It
> can include temperature sensors, voltage sensors, fan speed
> sensors and various additional features such as the ability to
> - control the speed of the fans. If you want this support you
> + control the speed of the fans. If you want this support you
> should say Y here and also to the specific driver(s) for your
> sensors chip(s) below.
Please no.
You can't pry two spaces after a period when using a
fixed width font from me.
And the use is nowhere consistent in the kernel as it's
less than 2:1 in favor of one style over the other.
$ git grep -i '[a-z][a-z]\. [a-z][a-z ]' | wc -l
146888
$ git grep -i '[a-z][a-z]\. [a-z][a-z ]' | wc -l
85195
The kernel Kconfig use ratio is similar.
$ git grep -i '[a-z][a-z]\. [a-z][a-z ]' -- '*/Kconfig*' | wc -l
5389
$ git grep -i '[a-z][a-z]\. [a-z][a-z ]' -- '*/Kconfig*' | wc -l
2463
And even in this specific file, it's reversed ratio
$ git grep -i '[a-z][a-z]\. [a-z][a-z ]' -- 'drivers/hwmon/Kconfig*' | wc -l
70
$ git grep -i '[a-z][a-z]\. [a-z][a-z ]' -- 'drivers/hwmon/Kconfig*' | wc -l
129
So if you _really_ wanted to do this, please do the
entire file consistently.
You seemed to do 118 conversions. Shouldn't there be 129?
next prev parent reply other threads:[~2018-12-02 7:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 20:09 [PATCH 1/2] hwmon: fix typo build -> built Corentin Labbe
2018-11-29 20:09 ` [PATCH 2/2] hwmon: Remove multiple space after dot Corentin Labbe
2018-12-01 18:34 ` Guenter Roeck
2018-12-01 20:27 ` Joe Perches [this message]
2018-12-01 20:34 ` Randy Dunlap
2018-12-01 18:32 ` [PATCH 1/2] hwmon: fix typo build -> built Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=188e822951d0b3a30cf4eea8ec0ea7b6d3bb4fca.camel@perches.com \
--to=joe@perches.com \
--cc=clabbe@baylibre.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox