From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f52.google.com (mail-dl1-f52.google.com [74.125.82.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE1CC34EF17 for ; Fri, 1 May 2026 06:10:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777615814; cv=none; b=Fh0ne1EYn4/2S7XDlebwIj0UI3VRLxU6EC6kGaXO8iyqX3avpmsuzX/pYwWzxyTxKdoY29TlsFcjABACzNi6Vgmm9PLoqIDA/Fc2oJIHBfxc1s1gF7RQPr65X3LFJFLc79wpl4SBrTgbL3Keuoz1y2ZpxQ2+PH2Z2vh3U5X+Nr8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777615814; c=relaxed/simple; bh=0IEGdnMyXloVDYwY7JeZH7JaeWxKh5toccHc/9uu6n4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Llow05OAXr34OfQmYcqBQ7+oMKBLF69CSikzOKGfFDdfJCy+lsyz9XyufmMwYs/kTPRTR7onL6vhTJDwaTijgo1KyJUCb39wyR/2jUDC9Ols+ve5CrbRB/pVMGzyxZIwSA4c6Cv8rbjffYZoqAPy2Jm+1Q2Rw+rMvYlUYlUtF0k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rL82xhDT; arc=none smtp.client-ip=74.125.82.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rL82xhDT" Received: by mail-dl1-f52.google.com with SMTP id a92af1059eb24-12c8ccc7755so2559362c88.0 for ; Thu, 30 Apr 2026 23:10:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777615812; x=1778220612; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=2796HLH4hTEiV4bO0wRpxpNZp2wuKSRdSVogoyw9+qA=; b=rL82xhDTRCVvslBcfFi2a8fD3r13oQ7gWMeGYdBWCxFvCK6ykAq/jVl16GU+0tjqT8 nxVPF+Rh3rIKCJVbv+m8QRYgeZb9SWhrJqWWmUqsLITcJxhnzY3rfzLoP4HLPZvniF1z UWixlTq3QYv1xVnsvG9zsd2UiKWgUsC3V4a9qzuptMiXwTO1mxM4z8Ix9kjE//ISOtmw gUUmmkX3uiRg5sAATIAqkjLOVcdUZFYb1ipYs8ro3/aIZhSXt8xgXd6Nx7EP/i4A9UH9 xKclqIS25FAR0BL3QX39h2RPn6biJyU3dM2DloEfeyB9kNUl48FQaUtzJBXzJdzfqzIC PTGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777615812; x=1778220612; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2796HLH4hTEiV4bO0wRpxpNZp2wuKSRdSVogoyw9+qA=; b=r1rOEwXsfYQ7oxCZE5t2SS8/empXLaCQt+Tjn8fo2Wee2QlkYs5bA7qgicrrxR0l/x w3gketUee+KNxyvgf2Fw0k27Wi9xIuBQdR+cUmjtk2yPEffqs2ODs+UQtq503RSeEg3x WaghwSQXnRxjijauy9lqCs1gStFTAdar0nt4ieGcAUPwlD1YiG2OJEDF0BiHHZ7pKdrg DBIdgm0kJXgHFJFJq5ZDP7A3lLaWrYXgjX2PkixvXuUQA49EpKZQIkk10q889Ds3BDon rqZoJiqGCYZQ0c73LZz8eGJtCgccu9JtArLUPsCxR3JnJfSx41ZSgR/emSmq0m0+HNmM XIsA== X-Forwarded-Encrypted: i=1; AFNElJ8Nessswu0JN6ae0QF8X/Sb0+FnYD1mJ5AU+EdICXT1NHUXrlw230fSpkEYGKvvs+/7LmICG/kGTqNObg==@vger.kernel.org X-Gm-Message-State: AOJu0YyiaYDC4DHGJs0RtzB+J7tQjT1ugOSX+wLO3LBjJ1xY5EnOHoKa 53DrV6q5KkI43++2B5KzMjNNcSnzHstCEr9xkjssJb6AtjAd4sRwTGtv X-Gm-Gg: AeBDietBL3dh8f2v0AFw6Y+HETm8r/IwuQJ5ogWNVZLohDIRbdztVMr6iECUt+dh1X5 35a96FV2dt+zyLzAGAUevor22zy+/zqavZ8+IPUyUZKDN31UhSfyZiZtC0+d8vNrJ5DUmFI5D+i Hns2pPNvGswmnNNCzE2KHw00FpnMhvhE//mAaI7LDW0we04D7MctBrg9pEGlI/BVsv3JCfPR67c CLkMJZxDYUXKkSxxhcJW6UeNiLf9I4saJ5zJX2MMz5PZwZdx3UEgyV9GkfTB/JV/S3WVz/hEvMD IDXjaU+cSSxRuYXSwApJ3eZf4OL7PXF8xFzX+HDTsvNkJF4vJthh3l8YRv/L4B3luFQ7jeV0295 /fYHHrcS7v+ko9fAWKH2D83t4ToqTcD5UShx7BbQPOQw/UrSBD19qGxnwyBwNmfzpMHK1SOK8SX rqeJfBXjtkQeOlEs/Ubx6NqZnid5hXzo9AjkO4pczhjNciaguFh50EBo9M1hJQohUD4l2jArcOt NXPHeStMK4= X-Received: by 2002:a05:7022:f103:b0:12a:7181:2f1a with SMTP id a92af1059eb24-12df820966emr693688c88.5.1777615811721; Thu, 30 Apr 2026 23:10:11 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12df81ec067sm2169548c88.0.2026.04.30.23.10.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2026 23:10:10 -0700 (PDT) Sender: Guenter Roeck Message-ID: <190bf39b-172d-4852-be86-1d7379d7d4aa@roeck-us.net> Date: Thu, 30 Apr 2026 23:10:09 -0700 Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 2/3] hwmon: ltc4283: Add support for the LTC4283 Swap Controller To: =?UTF-8?Q?Nuno_S=C3=A1?= Cc: sashiko@lists.linux.dev, =?UTF-8?Q?Nuno_S=C3=A1_via_B4_Relay?= , linux-hwmon@vger.kernel.org References: <20260430-ltc4283-support-v12-2-5dc9901f2567@analog.com> <20260430100343.45D31C2BCB3@smtp.kernel.org> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/30/26 09:50, Nuno Sá wrote: > On Thu, Apr 30, 2026 at 07:52:55AM -0700, Guenter Roeck wrote: >> On 4/30/26 03:03, sashiko-bot@kernel.org wrote: >> ... >>>> + id = (client->adapter->nr << 10) | client->addr; >>>> + adev = __devm_auxiliary_device_create(dev, KBUILD_MODNAME, "gpio", >>>> + &st->gpio_mask, id); >>>> + if (!adev) >>>> + return dev_err_probe(dev, -ENODEV, "Failed to add GPIO device\n"); >>> >>> Can this error path lead to a use-after-free? >>> >>> According to the I2C subsystem rules, debugfs entries attached to the >>> client debugfs directory are only cleaned up during the client device >>> removal function on driver unbind. >>> >>> If __devm_auxiliary_device_create() fails, the probe function aborts and >>> the devres subsystem frees the st pointer. However, the debugfs files >>> persist and retain operations that operate on the freed st pointer. >>> >> >> AI taking everything literally :-(. I'll have to reword that guidance again >> to include the probe error path. >> > > Yeah and it is annoying it always comes up with something that could > have been said before. Even more annoying some of are legit issues :) > Agreed, but I think it it is better that it finds the issues in multiple rounds than not finding them at all. And I have to say it is very human - the same happens to me as well when I do code reviews of complex patches. A major difference is that, unlike me, AI doesn't get tired. Guenter