fam15h_power on a4-4000?

fam15h_power on a4-4000?

[Trek]

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

reading the specs, it seems to me that the a4-4000 processor (amd fam
15h model 13h) has the tdp running average feature, implemented in
the fam15h_power module:

  D18F5xE0, page 456, BKDG for AMD Family 15h Models 10h-1Fh Processors
  http://support.amd.com/TechDocs/42300_15h_Mod_10h-1Fh_BKDG.pdf

if this assumption is correct, the module fails to probe the device
only because the pci id to query is different, so the attached patch
should fix the detection

it is untested as i'm not familiar with the hardware and i really
appreciate some suggestion from an expert here

c-ya!

[-- Attachment #2: fam15h_power-10h.diff --]
[-- Type: text/x-patch, Size: 1230 bytes --]

diff -ur linux/drivers/hwmon/fam15h_power.c linux-fam15h_power-10h/drivers/hwmon/fam15h_power.c
--- linux/drivers/hwmon/fam15h_power.c	2016-03-27 19:54:32.176763010 +0200
+++ linux-fam15h_power-10h/drivers/hwmon/fam15h_power.c	2016-03-27 20:00:02.048765885 +0200
@@ -304,6 +304,7 @@
 
 static const struct pci_device_id fam15h_power_id_table[] = {
 	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_15H_NB_F4) },
+	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_15H_M10H_NB_F4) },
 	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_15H_M30H_NB_F4) },
 	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_15H_M60H_NB_F4) },
 	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_15H_M70H_NB_F4) },
diff -ur linux/include/linux/pci_ids.h linux-fam15h_power-10h/include/linux/pci_ids.h
--- linux/include/linux/pci_ids.h	2016-03-27 19:55:45.768763651 +0200
+++ linux-fam15h_power-10h/include/linux/pci_ids.h	2016-03-27 20:00:22.724766065 +0200
@@ -521,6 +521,7 @@
 #define PCI_DEVICE_ID_AMD_11H_NB_MISC	0x1303
 #define PCI_DEVICE_ID_AMD_11H_NB_LINK	0x1304
 #define PCI_DEVICE_ID_AMD_15H_M10H_F3	0x1403
+#define PCI_DEVICE_ID_AMD_15H_M10H_NB_F4 0x1404
 #define PCI_DEVICE_ID_AMD_15H_M30H_NB_F3 0x141d
 #define PCI_DEVICE_ID_AMD_15H_M30H_NB_F4 0x141e
 #define PCI_DEVICE_ID_AMD_15H_M60H_NB_F3 0x1573

Re: fam15h_power on a4-4000?

[Guenter Roeck]

On Sun, Mar 27, 2016 at 08:13:40PM +0200, Trek wrote:
> reading the specs, it seems to me that the a4-4000 processor (amd fam
> 15h model 13h) has the tdp running average feature, implemented in
> the fam15h_power module:
> 
>   D18F5xE0, page 456, BKDG for AMD Family 15h Models 10h-1Fh Processors
>   http://support.amd.com/TechDocs/42300_15h_Mod_10h-1Fh_BKDG.pdf
> 
> if this assumption is correct, the module fails to probe the device
> only because the pci id to query is different, so the attached patch
> should fix the detection
> 
> it is untested as i'm not familiar with the hardware and i really
> appreciate some suggestion from an expert here
> 
> c-ya!

Let's ask the maintainer. Huang, is this correct ?

Also see comment inline.

Thanks,
Guenter

> diff -ur linux/drivers/hwmon/fam15h_power.c linux-fam15h_power-10h/drivers/hwmon/fam15h_power.c
> --- linux/drivers/hwmon/fam15h_power.c	2016-03-27 19:54:32.176763010 +0200
> +++ linux-fam15h_power-10h/drivers/hwmon/fam15h_power.c	2016-03-27 20:00:02.048765885 +0200
> @@ -304,6 +304,7 @@
>  
>  static const struct pci_device_id fam15h_power_id_table[] = {
>  	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_15H_NB_F4) },
> +	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_15H_M10H_NB_F4) },
>  	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_15H_M30H_NB_F4) },
>  	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_15H_M60H_NB_F4) },
>  	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_15H_M70H_NB_F4) },
> diff -ur linux/include/linux/pci_ids.h linux-fam15h_power-10h/include/linux/pci_ids.h
> --- linux/include/linux/pci_ids.h	2016-03-27 19:55:45.768763651 +0200
> +++ linux-fam15h_power-10h/include/linux/pci_ids.h	2016-03-27 20:00:22.724766065 +0200
> @@ -521,6 +521,7 @@
>  #define PCI_DEVICE_ID_AMD_11H_NB_MISC	0x1303
>  #define PCI_DEVICE_ID_AMD_11H_NB_LINK	0x1304
>  #define PCI_DEVICE_ID_AMD_15H_M10H_F3	0x1403
> +#define PCI_DEVICE_ID_AMD_15H_M10H_NB_F4 0x1404

New PCI IDs should not be added to this file unless used more than once.
Please see the comment at the top of the file.

>  #define PCI_DEVICE_ID_AMD_15H_M30H_NB_F3 0x141d
>  #define PCI_DEVICE_ID_AMD_15H_M30H_NB_F4 0x141e
>  #define PCI_DEVICE_ID_AMD_15H_M60H_NB_F3 0x1573

Re: fam15h_power on a4-4000?

[Huang Rui]

On Mon, Mar 28, 2016 at 02:51:31AM +0800, Guenter Roeck wrote:
> On Sun, Mar 27, 2016 at 08:13:40PM +0200, Trek wrote:
> > reading the specs, it seems to me that the a4-4000 processor (amd fam
> > 15h model 13h) has the tdp running average feature, implemented in
> > the fam15h_power module:
> > 
> >   D18F5xE0, page 456, BKDG for AMD Family 15h Models 10h-1Fh Processors
> >   http://support.amd.com/TechDocs/42300_15h_Mod_10h-1Fh_BKDG.pdf
> > 
> > if this assumption is correct, the module fails to probe the device
> > only because the pci id to query is different, so the attached patch
> > should fix the detection
> > 
> > it is untested as i'm not familiar with the hardware and i really
> > appreciate some suggestion from an expert here
> > 
> > c-ya!
> 
> Let's ask the maintainer. Huang, is this correct ?
> 
> Also see comment inline.
> 

OK.

Trek, have you tested it on Fam15h Models 10h-1fh platforms? I seem to
remember I tried it on that type of platforms, but the test data was
not right. So I didn't expose it at that time.

Thanks,
Rui

Re: fam15h_power on a4-4000?

[Trek]

On Mon, 28 Mar 2016 10:19:23 +0800
Huang Rui <ray.huang@amd.com> wrote:

> Trek, have you tested it on Fam15h Models 10h-1fh platforms? I seem to
> remember I tried it on that type of platforms, but the test data was
> not right. So I didn't expose it at that time.

thanks for your replies, I have just compiled the module for my kernel
version (3.16) with the patch applied and it returns these values:

fam15h_power-pci-00c4
Adapter: PCI adapter
power1:       10.56 W  (crit =  65.18 W)

the crit value is correct (the TDP of the a4-4000 is 65W) but the
actual usage is "fixed", always the same even at 100% usage of all cpu
cores and the integrated gpu

so the readings are incorrect and the patch is useless


I have strange readings also for the other drivers concerned with
monitoring my cpu/gpu:

k10temp-pci-00c3
Adapter: PCI adapter
temp1:         +0.0 C  (high = +70.0 C)
                       (crit = +70.0 C, hyst = +69.0 C)

radeon-pci-0008
Adapter: PCI adapter
temp1:         -1.0 C  (crit = +120.0 C, hyst = +90.0 C)

but at least they are incremented under full load and, reading the docs,
they are not really physical degrees, but some other measuring unit

thanks & c-ya!