Re: [RFC 5/8] ARM: socfpga: dts: Add Devkit A10-SR fields for Arria10

Thor Thayer
2016-03-31T18:28:03Z

On 03/30/2016 12:42 PM, Dinh Nguyen wrote:
> On Tue, 29 Mar 2016, tthayer@opensource.altera.com wrote:
>
>> From: Thor Thayer <tthayer@opensource.altera.com>
>>
>> Add the Altera Arria10 System Resource node. This is a Multi-Function
>> device with GPIO and HWMON support.
>>
>> Signed-off-by: Thor Thayer <tthayer@opensource.altera.com>
>>
>> + spi1: spi@ffda5000 {
>> + compatible = "snps,dw-apb-ssi";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0xffda5000 0x100>;
>> + interrupts = <0 102 4>;
>> + num-chipselect = <4>;
>> + bus-num = <0>;
>> + /*32bit_access;*/
>> + tx-dma-channel = <&pdma 16>;
>> + rx-dma-channel = <&pdma 17>;
>> + clocks = <&spi_m_clk>;
>> + status = "disabled";
>> + };
>> +
>
> I think you need to split this into 2 patches, 1 for adding the SPI nodes, and
> the 2nd for adding the slave device.
>
> BR,
> Dinh
>

OK. Thanks for reviewing.