From: Jean Delvare <jdelvare@suse.de>
To: Matt Ranostay <mranostay@gmail.com>
Cc: linux-hwmon@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
David Frey <david.frey@sensirion.com>
Subject: Re: [PATCH v2] hwmon: (sht3x) set initial jiffies to last_update
Date: Mon, 25 Jul 2016 10:49:36 +0200 [thread overview]
Message-ID: <20160725104936.3e940658@endymion> (raw)
In-Reply-To: <1469405132-7044-1-git-send-email-mranostay@gmail.com>
On Sun, 24 Jul 2016 17:05:32 -0700, Matt Ranostay wrote:
> Handling the wraparound requires the data->last_update to be set to an
> initial jiffies value. Otherwise on 32-bit systems you will not be able
> to request a reading till the 5 minute jiffies rollover happens.
>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: David Frey <david.frey@sensirion.com>
> Signed-off-by: Matt Ranostay <mranostay@gmail.com>
> ---
>
> Changes from v1:
> * document more in commit message the reason for the patch
> * mark last sample before driver load so initial reading can happen
> shortly after boot
>
> drivers/hwmon/sht3x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/sht3x.c b/drivers/hwmon/sht3x.c
> index b73a48832732..6ea99cd6ae79 100644
> --- a/drivers/hwmon/sht3x.c
> +++ b/drivers/hwmon/sht3x.c
> @@ -720,7 +720,7 @@ static int sht3x_probe(struct i2c_client *client,
> data->setup.blocking_io = false;
> data->setup.high_precision = true;
> data->mode = 0;
> - data->last_update = 0;
> + data->last_update = jiffies - msecs_to_jiffies(3000);
> data->client = client;
> crc8_populate_msb(sht3x_crc8_table, SHT3X_CRC8_POLYNOMIAL);
>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2016-07-25 8:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 0:05 [PATCH v2] hwmon: (sht3x) set initial jiffies to last_update Matt Ranostay
2016-07-25 8:49 ` Jean Delvare [this message]
2016-07-25 14:42 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725104936.3e940658@endymion \
--to=jdelvare@suse.de \
--cc=david.frey@sensirion.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mranostay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox