From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx2.suse.de ([195.135.220.15]:58409 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752271AbcGYItj (ORCPT ); Mon, 25 Jul 2016 04:49:39 -0400 Date: Mon, 25 Jul 2016 10:49:36 +0200 From: Jean Delvare To: Matt Ranostay Cc: linux-hwmon@vger.kernel.org, Guenter Roeck , David Frey Subject: Re: [PATCH v2] hwmon: (sht3x) set initial jiffies to last_update Message-ID: <20160725104936.3e940658@endymion> In-Reply-To: <1469405132-7044-1-git-send-email-mranostay@gmail.com> References: <1469405132-7044-1-git-send-email-mranostay@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-hwmon-owner@vger.kernel.org List-Id: linux-hwmon@vger.kernel.org On Sun, 24 Jul 2016 17:05:32 -0700, Matt Ranostay wrote: > Handling the wraparound requires the data->last_update to be set to an > initial jiffies value. Otherwise on 32-bit systems you will not be able > to request a reading till the 5 minute jiffies rollover happens. > > Cc: Guenter Roeck > Cc: David Frey > Signed-off-by: Matt Ranostay > --- > > Changes from v1: > * document more in commit message the reason for the patch > * mark last sample before driver load so initial reading can happen > shortly after boot > > drivers/hwmon/sht3x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/sht3x.c b/drivers/hwmon/sht3x.c > index b73a48832732..6ea99cd6ae79 100644 > --- a/drivers/hwmon/sht3x.c > +++ b/drivers/hwmon/sht3x.c > @@ -720,7 +720,7 @@ static int sht3x_probe(struct i2c_client *client, > data->setup.blocking_io = false; > data->setup.high_precision = true; > data->mode = 0; > - data->last_update = 0; > + data->last_update = jiffies - msecs_to_jiffies(3000); > data->client = client; > crc8_populate_msb(sht3x_crc8_table, SHT3X_CRC8_POLYNOMIAL); > Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support