From: Guenter Roeck <linux@roeck-us.net>
To: Jean Delvare <jdelvare@suse.de>
Cc: linux-hwmon@vger.kernel.org,
Alexander Kapshuk <alexander.kapshuk@gmail.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH 1/2] hwmon: (it87) Add missing sysfs attribute group terminator
Date: Mon, 29 Aug 2016 05:30:46 -0700 [thread overview]
Message-ID: <20160829123046.GA26130@roeck-us.net> (raw)
In-Reply-To: <20160829131823.776dd67b@endymion>
On Mon, Aug 29, 2016 at 01:18:23PM +0200, Jean Delvare wrote:
> Attribute array it87_attributes_in lacks its NULL terminator,
> causing random behavior when operating on the attribute group.
>
> Fixes: 52929715634a ("hwmon: (it87) Use is_visible for voltage sensors")
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: stable@vger.kernel.org
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/it87.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-4.7.orig/drivers/hwmon/it87.c 2016-07-04 08:01:00.000000000 +0200
> +++ linux-4.7/drivers/hwmon/it87.c 2016-08-29 12:04:52.926911625 +0200
> @@ -2015,6 +2015,7 @@ static struct attribute *it87_attributes
> &sensor_dev_attr_in10_input.dev_attr.attr, /* 41 */
> &sensor_dev_attr_in11_input.dev_attr.attr, /* 41 */
> &sensor_dev_attr_in12_input.dev_attr.attr, /* 41 */
> + NULL
> };
>
> static const struct attribute_group it87_group_in = {
>
>
> --
> Jean Delvare
> SUSE L3 Support
next prev parent reply other threads:[~2016-08-29 12:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 11:18 [PATCH 1/2] hwmon: (it87) Add missing sysfs attribute group terminator Jean Delvare
2016-08-29 11:33 ` [PATCH 2/2] hwmon: (it87) Drop useless comments Jean Delvare
2016-08-29 12:34 ` Guenter Roeck
2016-08-29 12:30 ` Guenter Roeck [this message]
2016-08-29 14:42 ` [PATCH 1/2] hwmon: (it87) Add missing sysfs attribute group terminator Alexander Kapshuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160829123046.GA26130@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alexander.kapshuk@gmail.com \
--cc=jdelvare@suse.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).