From: Rob Herring <robh@kernel.org>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: linux@roeck-us.net, linux-hwmon@vger.kernel.org,
iwamoto@allied-telesis.co.jp, Joshua.Scott@alliedtelesis.co.nz,
Kevin Tsai <ktsai@capellamicro.com>,
Wolfram Sang <wsa@the-dreams.de>,
Mark Rutland <mark.rutland@arm.com>,
Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCHv4] hwmon: Add tc654 driver
Date: Mon, 10 Oct 2016 16:54:42 -0500 [thread overview]
Message-ID: <20161010215442.GA22578@rob-hp-laptop> (raw)
In-Reply-To: <20161010212633.5436-1-chris.packham@alliedtelesis.co.nz>
On Tue, Oct 11, 2016 at 10:26:31AM +1300, Chris Packham wrote:
> Add support for the tc654 and tc655 fan controllers from Microchip.
>
> http://ww1.microchip.com/downloads/en/DeviceDoc/20001734C.pdf
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> Changes in v4:
> - tab-align values in #defines
> - ensure locking in set_pwm covers updating cached values
> - populate the cached value for the config register in tc654_probe()
>
> Changes in v3:
> - typofix in documentation
> - add missing value to tc654_pwm_map, re-generate based on datasheet.
> - remove unnecessary hwmon_dev member from struct tc654_data
> - bug fixes in set_fan_min() and show_pwm_mode()
> - miscellaneous style fixes
>
> Changes in v2:
> - Add Documentation/hwmon/tc654
> - Incorporate most of the review comments from Guenter. Additional error
> handling is added. Unused/unnecessary code is removed. I decided not
> to go down the regmap path yet. I may circle back to it when I look at
> using regmap in the adm9240 driver.
>
> .../devicetree/bindings/i2c/trivial-devices.txt | 2 +
Expect a merge conflict with the IIO tree.
Acked-by: Rob Herring <robh@kernel.org>
> Documentation/hwmon/tc654 | 31 ++
> drivers/hwmon/Kconfig | 11 +
> drivers/hwmon/Makefile | 1 +
> drivers/hwmon/tc654.c | 514 +++++++++++++++++++++
> 5 files changed, 559 insertions(+)
> create mode 100644 Documentation/hwmon/tc654
> create mode 100644 drivers/hwmon/tc654.c
next prev parent reply other threads:[~2016-10-10 21:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 22:57 [PATCHv1] hwmon: Add tc654 driver Guenter Roeck
2016-10-06 23:13 ` Chris Packham
2016-10-07 1:38 ` [PATCHv2] " Chris Packham
2016-10-07 18:29 ` Guenter Roeck
2016-10-09 21:21 ` Chris Packham
2016-10-09 22:12 ` [PATCHv3] " Chris Packham
2016-10-10 13:21 ` Guenter Roeck
2016-10-10 20:08 ` Chris Packham
2016-10-10 20:59 ` Guenter Roeck
2016-10-10 21:26 ` [PATCHv4] " Chris Packham
2016-10-10 21:54 ` Rob Herring [this message]
2016-10-12 13:03 ` Guenter Roeck
2016-10-12 20:17 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161010215442.GA22578@rob-hp-laptop \
--to=robh@kernel.org \
--cc=Joshua.Scott@alliedtelesis.co.nz \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=iwamoto@allied-telesis.co.jp \
--cc=jdelvare@suse.com \
--cc=ktsai@capellamicro.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox