From: Jean Delvare <jdelvare@suse.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Hardware Monitoring <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH v2] hwmon: (adt7462) Fix overflows seen when writing into limit attributes
Date: Fri, 9 Dec 2016 10:29:52 +0100 [thread overview]
Message-ID: <20161209102952.3ec51771@endymion> (raw)
In-Reply-To: <1481225209-12936-1-git-send-email-linux@roeck-us.net>
On Thu, 8 Dec 2016 11:26:49 -0800, Guenter Roeck wrote:
> Fix overflows seen when writing large values into temperature limit,
> voltage limit, and pwm hysteresis attributes.
>
> The input parameter to DIV_ROUND_CLOSEST() needs to be clamped to avoid
> such overflows.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> v2: Simplified clamping
> Separate clamp_val() and DIV_ROUND_CLOSEST() into two lines.
>
> drivers/hwmon/adt7462.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
> (...)
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
prev parent reply other threads:[~2016-12-09 9:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 19:26 [PATCH v2] hwmon: (adt7462) Fix overflows seen when writing into limit attributes Guenter Roeck
2016-12-09 9:29 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161209102952.3ec51771@endymion \
--to=jdelvare@suse.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox